[GitHub] [arrow] domoritz commented on a change in pull request #10183: ARROW-12393: [JS] [WIP] Drop closure compiler

[GitBox <gi...@apache.org>]

domoritz commented on a change in pull request #10183:
URL: https://github.com/apache/arrow/pull/10183#discussion_r621817736



##########
File path: js/gulpfile.js
##########
@@ -46,13 +44,10 @@ for (const [target, format] of combinations([`all`], [`all`])) {
 // a minifier, so we special case that here.
 knownTargets.forEach((target) => {
     const umd = taskName(target, `umd`);
-    const cls = taskName(UMDSourceTargets[target], `cls`);
+    const esm = taskName(target, `esm`);
     gulp.task(`build:${umd}`, gulp.series(
-        `build:${cls}`,
-        `clean:${umd}`, `compile:${umd}`, `package:${umd}`,
-        function remove_closure_tmp_files() {
-            return del(targetDir(target, `cls`))
-        }
+        `build:${esm}`,

Review comment:
       @trxcllnt I don't know much about gulp but this seems to run the same job twice when I run `yarn build -t es5`. How can I avoid that?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org