[GitHub] [arrow-datafusion] matthewmturner commented on pull request #2065: split datafusion-object-store module

[GitBox <gi...@apache.org>]

matthewmturner commented on pull request #2065:
URL: https://github.com/apache/arrow-datafusion/pull/2065#issuecomment-1076803178


   Overall looks good.  I think my only point, similar to what we discussed before, is on some of the `ObjectStore` functionality that is still hanging around in datafusion core i.e. `ListingTable` and functionality in `datasource`.  I know the `ObjectStore` doesnt need them and this keeps `datafusion-storage` light, which of course is nice.  To me they just seem logically coupled so at first was odd seeing the functionality split like that.
   
   That being said, i have given this more thought and given how the above mentioned functionalities leverage physical plan, etc. i do think it makes sense to have datafusion wrap these functionalities together.  just walking through my thought process out loud :)
   
   thanks for this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org