You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/03/31 07:57:39 UTC

[GitHub] [kafka] RivenSun2 opened a new pull request #11975: MINOR: Improve log output information

RivenSun2 opened a new pull request #11975:
URL: https://github.com/apache/kafka/pull/11975


   The printed object changes from `endpoint` to `endpoint.listenerName`, so the prompt information of the log should be kept uniform


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on pull request #11975: MINOR: Improve the log output information of SocketServer

Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11975:
URL: https://github.com/apache/kafka/pull/11975#issuecomment-1084265518


   @RivenSun2 , thanks for the PR, but I don't think the `endpoint` output has any problem here. Let's see if there are other opinion from other reviewers. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] RivenSun2 commented on pull request #11975: MINOR: Improve the log output information of SocketServer

Posted by GitBox <gi...@apache.org>.
RivenSun2 commented on pull request #11975:
URL: https://github.com/apache/kafka/pull/11975#issuecomment-1085441542


   @showuon ok, thanks for your review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on pull request #11975: MINOR: Improve the log output information of SocketServer

Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11975:
URL: https://github.com/apache/kafka/pull/11975#issuecomment-1085337302


   @RivenSun2 ,Thanks for the explanation. But I still think the `endpoint` is a better output. That is:
   1. `Created data-plane acceptor and processors for endpoint : ListenerName(PLAIN_PLUGIN_SSL)`
   2. `Created data-plane acceptor and processors for listenerName : ListenerName(PLAIN_PLUGIN_SSL)`
   
   I would choose (1). 
   Let's see if there are other opinions. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] RivenSun2 commented on pull request #11975: MINOR: Improve log output information

Posted by GitBox <gi...@apache.org>.
RivenSun2 commented on pull request #11975:
URL: https://github.com/apache/kafka/pull/11975#issuecomment-1084228786


   Hi @dajac @showuon 
   please help to review the PR .
   Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] RivenSun2 commented on pull request #11975: MINOR: Improve the log output information of SocketServer

Posted by GitBox <gi...@apache.org>.
RivenSun2 commented on pull request #11975:
URL: https://github.com/apache/kafka/pull/11975#issuecomment-1084317655


   @showuon Thanks for your reply.
   Here is the log printed by the previous code:
   `INFO [SocketServer brokerId=2] Created data-plane acceptor and processors for endpoint : EndPoint(null,9669,ListenerName(PLAIN_PLUGIN_SSL),SASL_SSL) (kafka.network.SocketServer)
   `
   
   Then this is the log printed by the code now:
   `INFO [SocketServer brokerId=2] Created data-plane acceptor and processors for endpoint : ListenerName(PLAIN_PLUGIN_SSL) (kafka.network.SocketServer)`
   
   I think the variable type we print changed and the variable type name for the log output should also change.
   WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11975: MINOR: Improve the log output information of SocketServer

Posted by GitBox <gi...@apache.org>.
RivenSun2 edited a comment on pull request #11975:
URL: https://github.com/apache/kafka/pull/11975#issuecomment-1085441542


   @showuon ok, thanks for your review. 
   I will close this PR if other people have the same opinion as you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org