You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/12 13:23:13 UTC

[GitHub] [airflow] AlessioM commented on pull request #13635: Fix string encoding in DockerOperator when using xcom / json in xcom.py

AlessioM commented on pull request #13635:
URL: https://github.com/apache/airflow/pull/13635#issuecomment-758651673


   this repo allows easy testing of the fix:
   https://github.com/AlessioM/airflow-xcom-issue
   
   however:
   the repo above has a dockeroperator that prints 10 lines (numbers 0 to 9, using a simple python script)
   xcom always contains all 10 lines, regardles if xcom_all is set or not
   
   I suspect that is because the DockerOperator uses docker-py's [client.attach](https://github.com/docker/docker-py/blob/6da140e26c1cbe8e362b328b1c78d9c736f3a1a2/docker/api/container.py#L17) wich does not return the logs separated by lines


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org