You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/07/07 16:00:27 UTC

[GitHub] [beam] egalpin commented on pull request #22183: Moves timestamp skew override to correct place

egalpin commented on PR #22183:
URL: https://github.com/apache/beam/pull/22183#issuecomment-1177848159

   R: @je-ik @kennknowles as you each have context on the prior 2 changes (https://github.com/apache/beam/pull/17112 and https://github.com/apache/beam/pull/21895) which this PR finally closes the loop on. 
   
   I wish I had better test coverage for this, but I've had great difficulty reproducing the `Output timestamps must be no earlier than the timestamp of the current input` error via unit tests.  I'm very open to ideas and input on the testing front.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org