You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "trim21 (via GitHub)" <gi...@apache.org> on 2024/12/25 00:30:09 UTC
[PR] fix exception name in python [opendal]
trim21 opened a new pull request, #5453:
URL: https://github.com/apache/opendal/pull/5453
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes https://github.com/apache/opendal/issues/5452
# Rationale for this change
after this patch:
```python
Traceback (most recent call last):
File "C:\Users\Trim21\proj\test\f.py", line 14, in <module>
op.read("non-exists-path")
opendal.exceptions.NotFound: NotFound (permanent) at stat, context: { service: redis, path: non-exists-path } => kv doesn't have this path
```
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
Yes, name in user exception message
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking-changes` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: exception name in python [opendal]
Posted by "messense (via GitHub)" <gi...@apache.org>.
messense commented on PR #5453:
URL: https://github.com/apache/opendal/pull/5453#issuecomment-2561524539
I'm not sure if we want to do a breaking change in a `bugfix` PR, can you split it into two PRs, one for the bugfix, another for the renames? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: exception name in python [opendal]
Posted by "messense (via GitHub)" <gi...@apache.org>.
messense merged PR #5453:
URL: https://github.com/apache/opendal/pull/5453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: exception name in python [opendal]
Posted by "messense (via GitHub)" <gi...@apache.org>.
messense commented on PR #5453:
URL: https://github.com/apache/opendal/pull/5453#issuecomment-2561526379
Oh right, I missed the `exception_module.add` part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: exception name in python [opendal]
Posted by "trim21 (via GitHub)" <gi...@apache.org>.
trim21 commented on PR #5453:
URL: https://github.com/apache/opendal/pull/5453#issuecomment-2561525327
> I'm not sure if we want to do a breaking change in a `bugfix` PR, can you split it into two PRs, one for the bugfix, another for the renames? Thanks!
Would you mind why it's a breaking change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: exception name in python [opendal]
Posted by "messense (via GitHub)" <gi...@apache.org>.
messense commented on PR #5453:
URL: https://github.com/apache/opendal/pull/5453#issuecomment-2561527569
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org