You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Nigel Daley (JIRA)" <ji...@apache.org> on 2009/02/26 05:11:04 UTC
[jira] Created: (HADOOP-5332) Make support for file append API
configurable
Make support for file append API configurable
---------------------------------------------
Key: HADOOP-5332
URL: https://issues.apache.org/jira/browse/HADOOP-5332
Project: Hadoop Core
Issue Type: Improvement
Components: dfs
Reporter: Nigel Daley
Assignee: dhruba borthakur
Priority: Blocker
Fix For: 0.19.2, 0.20.0
FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5332) Make support for file append API
configurable
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680273#action_12680273 ]
dhruba borthakur commented on HADOOP-5332:
------------------------------------------
The unit tests failed but most of the failures are unrelated. If Raghu agrees, then I can commit it.
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5332) Make support for file append API
configurable
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677495#action_12677495 ]
Raghu Angadi commented on HADOOP-5332:
--------------------------------------
yes, there needs to be a 0.19 version of this patch (since it is marked for 0.19.2). But I was not talking about it.
> Hi Raghu, thanks for the info. HADOOP-5225 has gone into 0.19 branch. The patch I attached ot this JIRA is for 0.20 and trunk
yes. should HADOOP-5225 also go into 0.20 and trunk? I think so, at least until HADOOP-4663 is committed. Two options for this : either marking HADOOP-4663 a blocker for 0.19.2 and 0.20 or get HADOOP-5225 in to this patch.
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5332) Make support for file append API
configurable
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-5332:
-------------------------------------
Attachment: disableAppend_0.19.patch
disableAppendTrunk.patch
1. change javadocs to reflect the change in behaviour of ClientProtocol.append
2. Indent braces in hdfs_test.c
3. Pulled in fix for HADOOP-5225
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5332) Make support for file append API
configurable
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-5332:
-------------------------------------
Attachment: disableAppendTrunk.patch
Make libhdfs unit tests test the append api.
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5332) Make support for file append API
configurable
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678118#action_12678118 ]
Nigel Daley commented on HADOOP-5332:
-------------------------------------
Also, the javadoc for the append method should mention it's new behavior based on the setting of the config variable.
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppend_0.19.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5332) Make support for file append API
configurable
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677182#action_12677182 ]
Raghu Angadi commented on HADOOP-5332:
--------------------------------------
Should datanode clean up tmp directory if this config is false (HADOOP-5225)? Seems required to match decisions made in 0.19.1 and 0.18. Otherwise users are not completely isolated.
Also should the default used in FSNamesystem.java for dfs.support.append to false?
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5332) Make support for file append API
configurable
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-5332:
-------------------------------------
Status: Patch Available (was: Open)
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5332) Make support for file append API
configurable
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-5332:
-------------------------------------
Status: Open (was: Patch Available)
Re-triggering hudson
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5332) Make support for file append API
configurable
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-5332:
-------------------------------------
Attachment: disableAppendTrunk.patch
Fixed unit test failures.
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5332) Make support for file append API
configurable
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-5332:
-------------------------------------
Status: Patch Available (was: Open)
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5332) Make support for file append API
configurable
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-5332:
-------------------------------------
Status: Open (was: Patch Available)
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5332) Make support for file append API
configurable
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680265#action_12680265 ]
Nigel Daley commented on HADOOP-5332:
-------------------------------------
Nicholas, Dhruba, Raghu, is this ready to commit?
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5332) Make support for file append API
configurable
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680784#action_12680784 ]
dhruba borthakur commented on HADOOP-5332:
------------------------------------------
I am going to commit this to 0.19, 0.20 and trunk very shortly.
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5332) Make support for file append API
configurable
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-5332:
-------------------------------------
Attachment: disableAppend_0.19.patch
Incorporate Raghu's review comments.
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (HADOOP-5332) Make support for file
append API configurable
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677782#action_12677782 ]
dhruba edited comment on HADOOP-5332 at 2/28/09 11:42 PM:
--------------------------------------------------------------------
We should commit HADOOP-5225 as it is into 0.20 and trunk as well.
was (Author: dhruba):
We should commit H-5225 as it is into 0.20 and trunk as well.
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppend_0.19.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5332) Make support for file append API
configurable
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679069#action_12679069 ]
Hadoop QA commented on HADOOP-5332:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12401374/disableAppend_0.19.patch
against trunk revision 750237.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 15 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/6/console
This message is automatically generated.
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5332) Make support for file append API
configurable
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677678#action_12677678 ]
Hadoop QA commented on HADOOP-5332:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12401073/disableAppendTrunk.patch
against trunk revision 748783.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 18 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/18/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/18/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/18/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/18/console
This message is automatically generated.
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (HADOOP-5332) Make support for file
append API configurable
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677782#action_12677782 ]
dhruba edited comment on HADOOP-5332 at 2/28/09 11:42 PM:
--------------------------------------------------------------------
We should commit H-5225 as it is into 0.20 and trunk as well.
was (Author: dhruba):
We should commit H-5525 as it is into 0.20 and trunk as well.
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppend_0.19.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5332) Make support for file append API
configurable
Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Yang updated HADOOP-5332:
------------------------------
Status: Open (was: Patch Available)
Resubmit patch to hudson, trunk test was broken by HADOOP-5409.
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5332) Make support for file append API
configurable
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677782#action_12677782 ]
dhruba borthakur commented on HADOOP-5332:
------------------------------------------
We should commit H-5525 as it is into 0.20 and trunk as well.
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppend_0.19.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5332) Make support for file append API
configurable
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-5332:
-------------------------------------
Status: Open (was: Patch Available)
Hudson applied the patch for 0.19 to trunk, hence tests failed.
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5332) Make support for file append API
configurable
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-5332:
-------------------------------------
Status: Open (was: Patch Available)
Canceling patch to incorporate review comments.
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppend_0.19.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5332) Make support for file append API
configurable
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680692#action_12680692 ]
Hadoop QA commented on HADOOP-5332:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12401791/disableAppendTrunk.patch
against trunk revision 752204.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 24 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/66/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/66/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/66/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/66/console
This message is automatically generated.
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5332) Make support for file append API
configurable
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680274#action_12680274 ]
dhruba borthakur commented on HADOOP-5332:
------------------------------------------
Let me also run the unit tests once again my own workspace
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5332) Make support for file append API
configurable
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-5332:
-------------------------------------
Status: Open (was: Patch Available)
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5332) Make support for file append API
configurable
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677171#action_12677171 ]
Hadoop QA commented on HADOOP-5332:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12401004/disableAppendTrunk.patch
against trunk revision 748090.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 9 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta/7/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta/7/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta/7/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta/7/console
This message is automatically generated.
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5332) Make support for file append API
configurable
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-5332:
-------------------------------------
Status: Patch Available (was: Open)
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5332) Make support for file append API
configurable
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-5332:
-------------------------------------
Attachment: disableAppendTrunk.patch
"append" is not supported by default. If you set the config property dfs.support.append, then append is enabled.
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5332) Make support for file append API
configurable
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-5332:
-------------------------------------
Resolution: Fixed
Fix Version/s: (was: 0.20.0)
Release Note: Appending to HDFS files is supported only if dfs.support.append is set to true.
Hadoop Flags: [Incompatible change, Reviewed]
Status: Resolved (was: Patch Available)
I just committed this.
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2
>
> Attachments: disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5332) Make support for file append API
configurable
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-5332:
-------------------------------------
Status: Patch Available (was: Open)
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5332) Make support for file append API
configurable
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677784#action_12677784 ]
Jim Kellerman commented on HADOOP-5332:
---------------------------------------
HADOOP-5525 ? I can't find it.
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppend_0.19.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5332) Make support for file append API
configurable
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678107#action_12678107 ]
Raghu Angadi commented on HADOOP-5332:
--------------------------------------
regd 0.19 patch for libhdfs : It should leave the curly braces in that were always there. Otherwise, indentation is not correct.
Since this jira is about using the config variable for append, I think it is simpler to incorporate HADOOP-5225 here that removes the tmp files only when appends are disabled. A whole new jira and associated overhead could be avoided.
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppend_0.19.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5332) Make support for file append API
configurable
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679382#action_12679382 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-5332:
------------------------------------------------
Dhruba, as [Rob mentioned before|https://issues.apache.org/jira/browse/HADOOP-5332?focusedCommentId=12678954#action_12678954], the default value in src/c++/libhdfs/tests/conf/hdfs-site.xml is set to be true but the description saying that it should be false. Which one is correct?
{noformat}
+ <name>dfs.support.append</name>
+ <value>true</value>
+ <description>Does HDFS allow appends to files?
+ This is currently set to false because there are bugs in the
+ "append code" and is not supported in any prodction cluster.
+ </description>
{noformat}
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5332) Make support for file append API
configurable
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680100#action_12680100 ]
Hadoop QA commented on HADOOP-5332:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12401563/disableAppendTrunk.patch
against trunk revision 751463.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 18 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/33/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/33/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/33/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/33/console
This message is automatically generated.
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5332) Make support for file append API
configurable
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-5332:
-------------------------------------
Status: Patch Available (was: Open)
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5332) Make support for file append API
configurable
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676909#action_12676909 ]
Nigel Daley commented on HADOOP-5332:
-------------------------------------
Dhruba, what about the libhdfs append tests?
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5332) Make support for file append API
configurable
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-5332:
-------------------------------------
Status: Patch Available (was: Open)
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5332) Make support for file append API
configurable
Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Yang updated HADOOP-5332:
------------------------------
Status: Patch Available (was: Open)
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5332) Make support for file append API
configurable
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-5332:
-------------------------------------
Attachment: disableAppend_0.19.patch
Changed a comment to to say that the libhdfs unit test is allowing hdfs appends.
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5332) Make support for file append API
configurable
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-5332:
-------------------------------------
Attachment: disableAppend_0.19.patch
Patch for 0.19 branch.
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppend_0.19.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5332) Make support for file append API
configurable
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-5332:
-------------------------------------
Attachment: disableAppendTrunk.patch
Changed a comment to to say that the libhdfs unit test is allowing hdfs appends.
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5332) Make support for file append API
configurable
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-5332:
-------------------------------------
Attachment: disableAppendTrunk.patch
ASttachign the same patch as before.
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5332) Make support for file append API
configurable
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677461#action_12677461 ]
dhruba borthakur commented on HADOOP-5332:
------------------------------------------
Hi Raghu, thanks for the info. HADOOP-5225 has gone into 0.19 branch. The patch I attached ot this JIRA is for 0.20 and trunk. If there is consensus that this patch needs to go into 019, then I will create a separate patch for 0.19 branch.
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5332) Make support for file append API
configurable
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-5332:
-------------------------------------
Attachment: disableAppendTrunk.patch
Fixed the two failed unit tests.
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5332) Make support for file append API
configurable
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680294#action_12680294 ]
Raghu Angadi commented on HADOOP-5332:
--------------------------------------
Since append is disabled by default, the tests that needed fixes in HADOOP-5225 should have append enabled. The current patch only has the FSDataset fix. This could explain two of the tests failed.
Apart from that, +1 for the patch.
TestPread failures in Hudson seem unrelated.
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5332) Make support for file append API
configurable
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681747#action_12681747 ]
Hudson commented on HADOOP-5332:
--------------------------------
Integrated in Hadoop-trunk #778 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/778/])
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2
>
> Attachments: disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5332) Make support for file append API
configurable
Posted by "Robert Chansler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678954#action_12678954 ]
Robert Chansler commented on HADOOP-5332:
-----------------------------------------
At the bottom of the patch, the _value_ is "true" but the _description_ says "set to false".
Is it correct that the default value should be false?
> Make support for file append API configurable
> ---------------------------------------------
>
> Key: HADOOP-5332
> URL: https://issues.apache.org/jira/browse/HADOOP-5332
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Nigel Daley
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.2, 0.20.0
>
> Attachments: disableAppend_0.19.patch, disableAppend_0.19.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch, disableAppendTrunk.patch
>
>
> FSNamesystem already has a private dfs.support.append config option. Make this public in src/hdfs/hdfs-default.xml and set the default to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.