[GitHub] [hadoop] ayushtkn commented on a change in pull request #3302: HDFS-16173.Improve CopyCommands#Put#executor queue configurability.

[GitBox <gi...@apache.org>]

ayushtkn commented on a change in pull request #3302:
URL: https://github.com/apache/hadoop/pull/3302#discussion_r690938256



##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/CopyCommands.java
##########
@@ -329,6 +335,22 @@ private void setNumberThreads(String numberThreadsString) {
       }
     }
 
+    private void setThreadPoolQueueSize(String numThreadPoolQueueSize) {
+      if (numThreadPoolQueueSize != null) {
+        int parsedValue = Integer.parseInt(numThreadPoolQueueSize);
+        if (parsedValue < 1) {
+          threadPoolQueueSize = 1024;

Review comment:
       Better to add a warn log line here, to denote the thread pool queue size was misconfigured and we are now using the default.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org