You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/02/16 00:23:01 UTC
[GitHub] [solr] janhoy opened a new pull request #643: Cleanup CHANGES.txt on branch_9_0
janhoy opened a new pull request #643:
URL: https://github.com/apache/solr/pull/643
* Long lines split
* Moved SOLR-15405 from 8.11.2 section to 9.0 section
* Removed 8.11.2 section from branch_9_0 (will re-add after 8.11.2 release)
* New "Docker" sub-heading since we have so many docker related changes
* New "Deprecation removals" sub-heading. Moved (most) removal JIRAs there
* Fixed some typos
* Remove SOLR-15631 from 9.0 since it was in 8.11.0
* Removed [SOLR-15222 ](https://issues.apache.org/jira/browse/SOLR-15222) and [SOLR-14486 ](https://issues.apache.org/jira/browse/SOLR-14486) from 9.0 section since they are obsoleted by later commits
This PR is for branch_9_0. Will first get it right on that branch, and then sync the final, authoritative version back to branch_9x and main once it is merged.
If you spot other JIRAs that obviously wrong in 9.0 CHANGES due to removals or other events after they were added, please shout out. Also, if you see multiple JIRAs on the same (new) 9.0 feature, let's group those together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on a change in pull request #643: Cleanup CHANGES.txt on branch_9_0
Posted by GitBox <gi...@apache.org>.
dsmiley commented on a change in pull request #643:
URL: https://github.com/apache/solr/pull/643#discussion_r807470696
##########
File path: solr/CHANGES.txt
##########
@@ -271,6 +247,89 @@ Build
* SOLR-15992: Globally forbid and exclude known bad dependencies (Kevin Risden)
+Docker
Review comment:
I like that it has its own section now!
Granted I don't like CHANGES.txt at all anymore but while we have it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #643: Cleanup CHANGES.txt on branch_9_0
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #643:
URL: https://github.com/apache/solr/pull/643#issuecomment-1042105986
I saw it, great If you want to fix that, it is in addVersion.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] anshumg commented on pull request #643: Cleanup CHANGES.txt on branch_9_0
Posted by GitBox <gi...@apache.org>.
anshumg commented on pull request #643:
URL: https://github.com/apache/solr/pull/643#issuecomment-1042704702
@janhoy - I'll close out the other PR against `main` and just create a PR against this so that we can move all changes into main in one go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on pull request #643: Cleanup CHANGES.txt on branch_9_0
Posted by GitBox <gi...@apache.org>.
madrob commented on pull request #643:
URL: https://github.com/apache/solr/pull/643#issuecomment-1041013583
Should library upgrades get their own section? Zookeeper, Hadoop (soon), Caffeine, HPPC, Carrot2, ICU4j, HttpClient, Jetty (soon)...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on pull request #643: Cleanup CHANGES.txt on branch_9_0
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on pull request #643:
URL: https://github.com/apache/solr/pull/643#issuecomment-1041926673
This looks good to me. I agree with Mike on the library upgrades. But maybe that deserves a section in the upgrade notes instead?
Also of note, the 9.1 and 10.0 sections have "Docker and modules have separate CHANGES.md files." at the top of them. I think this was added to the dev-tools, whenever David made that change, but it wasn't removed when the change was un-done. Anyone opposed to me cleaning that up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a change in pull request #643: Cleanup CHANGES.txt on branch_9_0
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #643:
URL: https://github.com/apache/solr/pull/643#discussion_r807815482
##########
File path: solr/CHANGES.txt
##########
@@ -271,6 +247,89 @@ Build
* SOLR-15992: Globally forbid and exclude known bad dependencies (Kevin Risden)
+Docker
Review comment:
I think the "Build" and "Docker" sections make sense for the major release, but for 9.1 we fall back to the normal headings, since there will likely be few changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy closed pull request #643: Cleanup CHANGES.txt on branch_9_0
Posted by GitBox <gi...@apache.org>.
janhoy closed pull request #643:
URL: https://github.com/apache/solr/pull/643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #643: Cleanup CHANGES.txt on branch_9_0
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #643:
URL: https://github.com/apache/solr/pull/643#issuecomment-1042818999
> @janhoy - I'll close out the other PR against `main` and just create a PR against this so that we can move all changes into main in one go.
Sure. I think I'll commit the 8.11.2 section removal separately to branch_9_0, an then it should be smooth sailing just to copy/paste the entire 9.0.0 section to the other branches once it is ready. Feel free to either merge this PR or continue committing to it as you see fit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #643: Cleanup CHANGES.txt on branch_9_0
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #643:
URL: https://github.com/apache/solr/pull/643#issuecomment-1064405249
Superseded by 692, closing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org