You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/09/30 07:17:01 UTC
[GitHub] [arrow] jorgecarleitao opened a new pull request #8307: ARROW-9753: [Rust] [DataFusion] Replaced Arc> by Box<>
jorgecarleitao opened a new pull request #8307:
URL: https://github.com/apache/arrow/pull/8307
This PR is built on top of #8225 and Replaces `Arc<Mutex<dyn ...>>` to `Box<dyn ...>`.
In the TopK example, I had to move some functions away from the `impl`. This is because `self` cannot be borrowed as mutable and immutable at the same time, and, during iteration, it was being borrowed as mutable (to update the BTree) and as immutable (to access the `input`). There is probably a better way of achieving this e.g. via interior mutability.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove closed pull request #8307: ARROW-9753: [Rust] [DataFusion] Replaced Arc> by Box<>
Posted by GitBox <gi...@apache.org>.
andygrove closed pull request #8307:
URL: https://github.com/apache/arrow/pull/8307
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8307: ARROW-9753: [Rust] [DataFusion] Replaced Arc> by Box<>
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8307:
URL: https://github.com/apache/arrow/pull/8307#issuecomment-701212076
https://issues.apache.org/jira/browse/ARROW-9753
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #8307: ARROW-9753: [Rust] [DataFusion] Replaced Arc> by Box<>
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #8307:
URL: https://github.com/apache/arrow/pull/8307#issuecomment-702227276
I think that the reason is that an iterator like `RecordBatchReader` needs to be mutable to be iterated upon (regardless of whether we use `next_batch` or `into_iter`), while an `Arc` would require it to be immutable. `Box` implements `BorrowMut`, which addresses this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org