You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2018/11/05 12:22:08 UTC

[GitHub] spark pull request #22948: [SPARK-25944][R][BUILD] AppVeyor change to latest...

GitHub user HyukjinKwon opened a pull request:

    https://github.com/apache/spark/pull/22948

    [SPARK-25944][R][BUILD] AppVeyor change to latest R version (3.5.1)

    ## What changes were proposed in this pull request?
    
    R 3.5.1 is released 2018-07-02. This PR targets to changes R version from 3.4.1 to 3.5.1.
    
    ## How was this patch tested?
    
    AppVeyor

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HyukjinKwon/spark SPARK-25944

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/22948.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22948
    
----
commit 472d339254e86d14ed420320821bec26abe3062e
Author: hyukjinkwon <gu...@...>
Date:   2018-11-05T12:19:54Z

    AppVeyor change to latest R version (3.5.1)

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22948: [SPARK-25944][R][BUILD] AppVeyor change to latest R vers...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22948
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #22948: [SPARK-25944][R][BUILD] AppVeyor change to latest...

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22948#discussion_r231762531
  
    --- Diff: dev/appveyor-install-dependencies.ps1 ---
    @@ -115,7 +115,7 @@ $env:Path += ";$env:HADOOP_HOME\bin"
     Pop-Location
     
     # ========================== R
    -$rVer = "3.4.1"
    +$rVer = "3.5.1"
     $rToolsVer = "3.4.0"
    --- End diff --
    
    Oh~ latest looks 3.5. Let me try to update aswell shortly.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #22948: [SPARK-25944][R][BUILD] AppVeyor change to latest...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/22948


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22948: [SPARK-25944][R][BUILD] AppVeyor change to latest R vers...

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/22948
  
    Merged to master.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22948: [SPARK-25944][R][BUILD] AppVeyor change to latest R vers...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22948
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22948: [SPARK-25944][R][BUILD] AppVeyor change to latest R vers...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22948
  
    **[Test build #98474 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98474/testReport)** for PR 22948 at commit [`472d339`](https://github.com/apache/spark/commit/472d339254e86d14ed420320821bec26abe3062e).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22948: [SPARK-25944][R][BUILD] AppVeyor change to latest R vers...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22948
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98474/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22948: [SPARK-25944][R][BUILD] AppVeyor change to latest R vers...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22948
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4771/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #22948: [SPARK-25944][R][BUILD] AppVeyor change to latest...

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22948#discussion_r231598045
  
    --- Diff: dev/appveyor-install-dependencies.ps1 ---
    @@ -115,7 +115,7 @@ $env:Path += ";$env:HADOOP_HOME\bin"
     Pop-Location
     
     # ========================== R
    -$rVer = "3.4.1"
    +$rVer = "3.5.1"
     $rToolsVer = "3.4.0"
    --- End diff --
    
    is there update to rtool?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22948: [SPARK-25944][R][BUILD] AppVeyor change to latest R vers...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22948
  
    **[Test build #98474 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98474/testReport)** for PR 22948 at commit [`472d339`](https://github.com/apache/spark/commit/472d339254e86d14ed420320821bec26abe3062e).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22948: [SPARK-25944][R][BUILD] AppVeyor change to latest R vers...

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/22948
  
    cc @felixcheung 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org