You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Owen O'Malley (JIRA)" <ji...@apache.org> on 2008/09/24 07:05:44 UTC
[jira] Created: (HADOOP-4259) findbugs should run over the
tools.jar also
findbugs should run over the tools.jar also
-------------------------------------------
Key: HADOOP-4259
URL: https://issues.apache.org/jira/browse/HADOOP-4259
Project: Hadoop Core
Issue Type: Test
Components: test
Reporter: Owen O'Malley
Currently the findbugs target doesn't include the tools.jar, as I discovered when I moved a class from tools.jar to hadoop.jar and got hit by a findbugs warning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4259) findbugs should run over the
tools.jar also
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-4259:
----------------------------------
Priority: Minor (was: Major)
Affects Version/s: 0.18.0
Fix Version/s: 0.19.0
Assignee: Chris Douglas
> findbugs should run over the tools.jar also
> -------------------------------------------
>
> Key: HADOOP-4259
> URL: https://issues.apache.org/jira/browse/HADOOP-4259
> Project: Hadoop Core
> Issue Type: Test
> Components: test
> Affects Versions: 0.18.0
> Reporter: Owen O'Malley
> Assignee: Chris Douglas
> Priority: Minor
> Fix For: 0.19.0
>
> Attachments: 4259-0.patch
>
>
> Currently the findbugs target doesn't include the tools.jar, as I discovered when I moved a class from tools.jar to hadoop.jar and got hit by a findbugs warning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4259) findbugs should run over the
tools.jar also
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634339#action_12634339 ]
Hadoop QA commented on HADOOP-4259:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12390862/4259-0.patch
against trunk revision 698721.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 1 new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3364/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3364/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3364/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3364/console
This message is automatically generated.
> findbugs should run over the tools.jar also
> -------------------------------------------
>
> Key: HADOOP-4259
> URL: https://issues.apache.org/jira/browse/HADOOP-4259
> Project: Hadoop Core
> Issue Type: Test
> Components: test
> Affects Versions: 0.18.0
> Reporter: Owen O'Malley
> Assignee: Chris Douglas
> Priority: Minor
> Fix For: 0.19.0
>
> Attachments: 4259-0.patch
>
>
> Currently the findbugs target doesn't include the tools.jar, as I discovered when I moved a class from tools.jar to hadoop.jar and got hit by a findbugs warning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4259) findbugs should run over the
tools.jar also
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-4259:
----------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Chris!
> findbugs should run over the tools.jar also
> -------------------------------------------
>
> Key: HADOOP-4259
> URL: https://issues.apache.org/jira/browse/HADOOP-4259
> Project: Hadoop Core
> Issue Type: Test
> Components: test
> Affects Versions: 0.18.0
> Reporter: Owen O'Malley
> Assignee: Chris Douglas
> Priority: Minor
> Fix For: 0.19.0
>
> Attachments: 4259-0.patch
>
>
> Currently the findbugs target doesn't include the tools.jar, as I discovered when I moved a class from tools.jar to hadoop.jar and got hit by a findbugs warning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4259) findbugs should run over the
tools.jar also
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-4259:
----------------------------------
Attachment: 4259-0.patch
Picks up the dead store in InputSampler fixed in HADOOP-4247.
> findbugs should run over the tools.jar also
> -------------------------------------------
>
> Key: HADOOP-4259
> URL: https://issues.apache.org/jira/browse/HADOOP-4259
> Project: Hadoop Core
> Issue Type: Test
> Components: test
> Reporter: Owen O'Malley
> Attachments: 4259-0.patch
>
>
> Currently the findbugs target doesn't include the tools.jar, as I discovered when I moved a class from tools.jar to hadoop.jar and got hit by a findbugs warning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4259) findbugs should run over the
tools.jar also
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635145#action_12635145 ]
Hudson commented on HADOOP-4259:
--------------------------------
Integrated in Hadoop-trunk #616 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/616/])
> findbugs should run over the tools.jar also
> -------------------------------------------
>
> Key: HADOOP-4259
> URL: https://issues.apache.org/jira/browse/HADOOP-4259
> Project: Hadoop Core
> Issue Type: Test
> Components: test
> Affects Versions: 0.18.0
> Reporter: Owen O'Malley
> Assignee: Chris Douglas
> Priority: Minor
> Fix For: 0.19.0
>
> Attachments: 4259-0.patch
>
>
> Currently the findbugs target doesn't include the tools.jar, as I discovered when I moved a class from tools.jar to hadoop.jar and got hit by a findbugs warning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4259) findbugs should run over the
tools.jar also
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-4259:
----------------------------------
Status: Patch Available (was: Open)
> findbugs should run over the tools.jar also
> -------------------------------------------
>
> Key: HADOOP-4259
> URL: https://issues.apache.org/jira/browse/HADOOP-4259
> Project: Hadoop Core
> Issue Type: Test
> Components: test
> Affects Versions: 0.18.0
> Reporter: Owen O'Malley
> Assignee: Chris Douglas
> Priority: Minor
> Fix For: 0.19.0
>
> Attachments: 4259-0.patch
>
>
> Currently the findbugs target doesn't include the tools.jar, as I discovered when I moved a class from tools.jar to hadoop.jar and got hit by a findbugs warning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.