[GitHub] [netbeans] neilcsmith-net commented on issue #1371: [NETBEANS-2800] - Repairs for Unable to create Servlet/Filter in Java EE 8 web application

[GitBox <gi...@apache.org>]

neilcsmith-net commented on issue #1371: [NETBEANS-2800] - Repairs for Unable to create Servlet/Filter in Java EE 8 web application
URL: https://github.com/apache/netbeans/pull/1371#issuecomment-510826572
 
 
   Unfortunately this PR is broken.  I've tried manually creating a patch based on your last commit and it also fails to build with the same error as in Travis
   
   ```
   ... netbeans/enterprise/j2ee.dd/build.xml:341: Replace: source file ...netbeans/enterprise/j2ee.dd/src/org/netbeans/modules/j2ee/dd/impl/web/model_4_0_frag/WebFragment.java doesn't exist
   ```
   
   It looks like the .gitignore file at https://github.com/apache/netbeans/blob/master/enterprise/j2ee.dd/.gitignore needs updating for the newly generated files too.
   
   I think you're going to have to reset your fork (or delete and create a new fork), keep master clean and in sync, apply these changes in a PR-specific branch, check it builds, and resubmit the PR.
   
   Let me know if that's feasible today and I'll hold off beta4 build.  Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists