You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/04/25 15:44:52 UTC

[GitHub] andrzej-kaczmarek commented on a change in pull request #1056: bsp/nrf52840pdk: replace bitbang by native uart for UART1

andrzej-kaczmarek commented on a change in pull request #1056: bsp/nrf52840pdk: replace bitbang by native uart for UART1
URL: https://github.com/apache/mynewt-core/pull/1056#discussion_r184109486
 
 

 ##########
 File path: hw/bsp/nrf52840pdk/src/hal_bsp.c
 ##########
 @@ -315,9 +313,9 @@ hal_bsp_init(void)
     assert(rc == 0);
 #endif
 
-#if MYNEWT_VAL(UART_1)
-    rc = os_dev_create((struct os_dev *) &os_bsp_bitbang_uart1, "uart1",
-      OS_DEV_INIT_PRIMARY, 0, uart_bitbang_init, (void *)&os_bsp_uart1_cfg);
+#if MYNEWT_VAL(UART_0)
 
 Review comment:
   should be 'UART_1'

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services