You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by James Peach <jp...@apache.org> on 2017/05/27 18:37:00 UTC
protected github master branch?
Hi all,
I tried to commit #1986 this morning:
$ git push
Counting objects: 12, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (12/12), done.
Writing objects: 100% (12/12), 1.42 KiB | 0 bytes/s, done.
Total 12 (delta 11), reused 0 (delta 0)
remote: Resolving deltas: 100% (11/11), completed with 11 local objects.
remote: error: GH006: Protected branch update failed for
refs/heads/master.
remote: error: 7 of 7 required status checks are expected. At least one
approved review is required by reviewers with write access.
To github.com:apache/trafficserver.git
! [remote rejected] master -> master (protected branch hook declined)
error: failed to push some refs to
'git@github.com:apache/trafficserver.git'
AFAICT the CI integration is stuck on this PR. I don’t think that we
should be blocking on this.
J
Re: protected github master branch?
Posted by Leif Hedstrom <zw...@apache.org>.
> On May 27, 2017, at 12:37 PM, James Peach <jp...@apache.org> wrote:
>
> Hi all,
>
> I tried to commit #1986 this morning:
>
> $ git push
> Counting objects: 12, done.
I turned off (effectively) the autest check yesterday morning. Basically, it will not run, and always returns a status OK. Hopefully we can resolve this very soon, I think it’s a very valuable check that we should have enabled.
Cheers,
— leif
Re: protected github master branch?
Posted by Alan Carroll <so...@yahoo-inc.com.INVALID>.
As far as I know, you can't directly commit to the github ATS repo. You can only do PR's and those have to be reviewed. In other words, this is now expected behavior.
On Saturday, May 27, 2017, 1:37:17 PM CDT, James Peach <jp...@apache.org> wrote:Hi all,
I tried to commit #1986 this morning:
$ git push
Counting objects: 12, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (12/12), done.
Writing objects: 100% (12/12), 1.42 KiB | 0 bytes/s, done.
Total 12 (delta 11), reused 0 (delta 0)
remote: Resolving deltas: 100% (11/11), completed with 11 local objects.
remote: error: GH006: Protected branch update failed for
refs/heads/master.
remote: error: 7 of 7 required status checks are expected. At least one
approved review is required by reviewers with write access.
To github.com:apache/trafficserver.git
! [remote rejected] master -> master (protected branch hook declined)
error: failed to push some refs to
'git@github.com:apache/trafficserver.git'
AFAICT the CI integration is stuck on this PR. I don’t think that we
should be blocking on this.
J