You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/03/01 06:15:20 UTC
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #8226: [Bug][Vectorized] fix arithmetic calculate get wrong result
EmmyMiao87 commented on a change in pull request #8226:
URL: https://github.com/apache/incubator-doris/pull/8226#discussion_r816475600
##########
File path: fe/fe-core/src/main/cup/sql_parser.cup
##########
@@ -4951,24 +4951,44 @@ window_boundary ::=
arithmetic_expr ::=
expr:e1 STAR expr:e2
{: RESULT = new ArithmeticExpr(ArithmeticExpr.Operator.MULTIPLY, e1, e2); :}
+ | KW_MULTIPLY LPAREN expr:e1 COMMA expr:e2 RPAREN
Review comment:
```functioname(param1, param2)``` is belongs to FunctionCallExpr .
If each functionname has to add grammar, the grammar file will not be able to be put down long ago
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org