[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #2575: Remove `Union::alias`

[GitBox <gi...@apache.org>]

andygrove commented on code in PR #2575:
URL: https://github.com/apache/arrow-datafusion/pull/2575#discussion_r878176903


##########
datafusion/core/src/logical_plan/builder.rs:
##########
@@ -432,8 +432,50 @@ impl LogicalPlanBuilder {
     }
 
     /// Apply a union, preserving duplicate rows
-    pub fn union(&self, plan: LogicalPlan) -> Result<Self> {
-        Ok(Self::from(union_with_alias(self.plan.clone(), plan, None)?))
+    pub fn union(&self, right_plan: LogicalPlan) -> Result<Self> {
+        let left_plan = self.plan.clone();

Review Comment:
   This logic is moved from the `union_with_alias` function but no longer references the alias



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org