You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/09 13:54:09 UTC
[GitHub] [spark] luluorta opened a new pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
luluorta opened a new pull request #30299:
URL: https://github.com/apache/spark/pull/30299
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR makes internal classes of SparkSession always using active SQLConf. We should remove all `conf: SQLConf`s from ctor-parameters of this classes (`Analyzer`, `SparkPlanner`, `SessionCatalog`, `CatalogManager` `SparkSqlParser` and etc.) and use `SQLConf.get` instead.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Code refine.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Existing test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] luluorta commented on a change in pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
luluorta commented on a change in pull request #30299:
URL: https://github.com/apache/spark/pull/30299#discussion_r521142212
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -42,7 +42,7 @@ import org.apache.spark.sql.catalyst.trees.TreeNodeRef
import org.apache.spark.sql.catalyst.util.toPrettySQL
import org.apache.spark.sql.connector.catalog._
import org.apache.spark.sql.connector.catalog.CatalogV2Implicits._
-import org.apache.spark.sql.connector.catalog.TableChange.{AddColumn, After, ColumnChange, ColumnPosition, DeleteColumn, RenameColumn, UpdateColumnComment, UpdateColumnNullability, UpdateColumnPosition, UpdateColumnType}
+import org.apache.spark.sql.connector.catalog.TableChange.{First => _, _}
Review comment:
reverted
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-724535074
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-728027341
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35762/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-727809685
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-724630363
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] luluorta commented on a change in pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
luluorta commented on a change in pull request #30299:
URL: https://github.com/apache/spark/pull/30299#discussion_r521081119
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/HasConf.scala
##########
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.catalyst
+
+import org.apache.spark.sql.internal.SQLConf
+
+/**
+ * Trait for shared SQLConf.
+ */
+trait HasConf {
Review comment:
I agree, ` SQLConfHelper` is better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-724039324
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-725478673
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35545/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-724534405
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-727791622
**[Test build #131139 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131139/testReport)** for PR 30299 at commit [`bf1e56a`](https://github.com/apache/spark/commit/bf1e56a87d662b9657e5f46380628b06b9c9e359).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-724535643
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130821/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-724630380
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130857/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-724422114
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35430/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] luluorta commented on a change in pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
luluorta commented on a change in pull request #30299:
URL: https://github.com/apache/spark/pull/30299#discussion_r521141904
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/HasConf.scala
##########
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.catalyst
+
+import org.apache.spark.sql.internal.SQLConf
+
+/**
+ * Trait for shared SQLConf.
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-724535084
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-724629950
**[Test build #130857 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130857/testReport)** for PR 30299 at commit [`b5366df`](https://github.com/apache/spark/commit/b5366df94eeaf00ec41c40a38bcf9105f836ec1b).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-724430622
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35430/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-727828601
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35742/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-725617359
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-725390721
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35534/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-724441695
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35432/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-724034331
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #30299:
URL: https://github.com/apache/spark/pull/30299#discussion_r521251047
##########
File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql
##########
@@ -149,7 +149,7 @@ select to_timestamp('2019-10-06 A', 'yyyy-MM-dd GGGGG');
select to_timestamp('22 05 2020 Friday', 'dd MM yyyy EEEEEE');
select to_timestamp('22 05 2020 Friday', 'dd MM yyyy EEEEE');
select unix_timestamp('22 05 2020 Friday', 'dd MM yyyy EEEEE');
-select from_json('{"time":"26/October/2015"}', 'time Timestamp', map('timestampFormat', 'dd/MMMMM/yyyy'));
+select from_json('{"timestamp":"26/October/2015"}', 'timestamp Timestamp', map('timestampFormat', 'dd/MMMMM/yyyy'));
Review comment:
`timestamp` is also reserved in ANSI. How about `ts`?
##########
File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql
##########
@@ -149,7 +149,7 @@ select to_timestamp('2019-10-06 A', 'yyyy-MM-dd GGGGG');
select to_timestamp('22 05 2020 Friday', 'dd MM yyyy EEEEEE');
select to_timestamp('22 05 2020 Friday', 'dd MM yyyy EEEEE');
select unix_timestamp('22 05 2020 Friday', 'dd MM yyyy EEEEE');
-select from_json('{"time":"26/October/2015"}', 'time Timestamp', map('timestampFormat', 'dd/MMMMM/yyyy'));
+select from_json('{"timestamp":"26/October/2015"}', 'timestamp Timestamp', map('timestampFormat', 'dd/MMMMM/yyyy'));
Review comment:
`timestamp` is also reserved in ANSI standard. How about `ts`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] luluorta commented on a change in pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
luluorta commented on a change in pull request #30299:
URL: https://github.com/apache/spark/pull/30299#discussion_r523940307
##########
File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql
##########
@@ -149,7 +149,7 @@ select to_timestamp('2019-10-06 A', 'yyyy-MM-dd GGGGG');
select to_timestamp('22 05 2020 Friday', 'dd MM yyyy EEEEEE');
select to_timestamp('22 05 2020 Friday', 'dd MM yyyy EEEEE');
select unix_timestamp('22 05 2020 Friday', 'dd MM yyyy EEEEE');
-select from_json('{"time":"26/October/2015"}', 'time Timestamp', map('timestampFormat', 'dd/MMMMM/yyyy'));
-select from_json('{"date":"26/October/2015"}', 'date Date', map('dateFormat', 'dd/MMMMM/yyyy'));
-select from_csv('26/October/2015', 'time Timestamp', map('timestampFormat', 'dd/MMMMM/yyyy'));
-select from_csv('26/October/2015', 'date Date', map('dateFormat', 'dd/MMMMM/yyyy'));
+select from_json('{"ts":"26/October/2015"}', 'ts Timestamp', map('timestampFormat', 'dd/MMMMM/yyyy'));
Review comment:
I opened a new PR for this issue [https://github.com/apache/spark/pull/30357](https://github.com/apache/spark/pull/30357)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-725617359
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-724029339
**[Test build #130790 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130790/testReport)** for PR 30299 at commit [`ad9d6d2`](https://github.com/apache/spark/commit/ad9d6d2e8b99805ce04373bed3ff3fa33f5503c3).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-725249564
**[Test build #130913 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130913/testReport)** for PR 30299 at commit [`7047924`](https://github.com/apache/spark/commit/70479247efe6a6b4b3e4d653281ce3a4ea8c5224).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-727809685
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] luluorta commented on a change in pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
luluorta commented on a change in pull request #30299:
URL: https://github.com/apache/spark/pull/30299#discussion_r521134961
##########
File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql
##########
@@ -149,7 +149,7 @@ select to_timestamp('2019-10-06 A', 'yyyy-MM-dd GGGGG');
select to_timestamp('22 05 2020 Friday', 'dd MM yyyy EEEEEE');
select to_timestamp('22 05 2020 Friday', 'dd MM yyyy EEEEE');
select unix_timestamp('22 05 2020 Friday', 'dd MM yyyy EEEEE');
-select from_json('{"time":"26/October/2015"}', 'time Timestamp', map('timestampFormat', 'dd/MMMMM/yyyy'));
+select from_json('{"timestamp":"26/October/2015"}', 'timestamp Timestamp', map('timestampFormat', 'dd/MMMMM/yyyy'));
Review comment:
After this PR, dynamically set "spark.sql.ansi.enabled" actually takes effect in parsing phase. This query will failed parsing cause `time` is a reserved key word of SQL standard.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-725399747
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #30299:
URL: https://github.com/apache/spark/pull/30299#discussion_r520578390
##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveTableScanExec.scala
##########
@@ -60,8 +59,6 @@ case class HiveTableScanExec(
require(partitionPruningPred.isEmpty || relation.isPartitioned,
"Partition pruning predicates only supported for partitioned tables.")
- override def conf: SQLConf = sparkSession.sessionState.conf
Review comment:
This actually makes sense, to make sure the conf matches the spark session. How about we move this override to `SparkPlan`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-728080132
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-727846909
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-725461013
**[Test build #130929 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130929/testReport)** for PR 30299 at commit [`ce97a61`](https://github.com/apache/spark/commit/ce97a61d904e2a5a37bc65168ed8773a685c5bf6).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-724535074
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-725462281
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-728133328
GA passed, merging to master, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-727833976
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35744/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #30299:
URL: https://github.com/apache/spark/pull/30299#discussion_r520565272
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -42,7 +42,7 @@ import org.apache.spark.sql.catalyst.trees.TreeNodeRef
import org.apache.spark.sql.catalyst.util.toPrettySQL
import org.apache.spark.sql.connector.catalog._
import org.apache.spark.sql.connector.catalog.CatalogV2Implicits._
-import org.apache.spark.sql.connector.catalog.TableChange.{AddColumn, After, ColumnChange, ColumnPosition, DeleteColumn, RenameColumn, UpdateColumnComment, UpdateColumnNullability, UpdateColumnPosition, UpdateColumnType}
+import org.apache.spark.sql.connector.catalog.TableChange.{First => _, _}
Review comment:
unnecessary change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-725288719
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35519/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #30299:
URL: https://github.com/apache/spark/pull/30299#discussion_r521545103
##########
File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql
##########
@@ -149,7 +149,7 @@ select to_timestamp('2019-10-06 A', 'yyyy-MM-dd GGGGG');
select to_timestamp('22 05 2020 Friday', 'dd MM yyyy EEEEEE');
select to_timestamp('22 05 2020 Friday', 'dd MM yyyy EEEEE');
select unix_timestamp('22 05 2020 Friday', 'dd MM yyyy EEEEE');
-select from_json('{"time":"26/October/2015"}', 'time Timestamp', map('timestampFormat', 'dd/MMMMM/yyyy'));
-select from_json('{"date":"26/October/2015"}', 'date Date', map('dateFormat', 'dd/MMMMM/yyyy'));
-select from_csv('26/October/2015', 'time Timestamp', map('timestampFormat', 'dd/MMMMM/yyyy'));
-select from_csv('26/October/2015', 'date Date', map('dateFormat', 'dd/MMMMM/yyyy'));
+select from_json('{"ts":"26/October/2015"}', 'ts Timestamp', map('timestampFormat', 'dd/MMMMM/yyyy'));
Review comment:
It was a bug before that the parser used in `from_json` to parse the schema string sticks to the configs of the first created session in the current thread. Now the parser always use the active conf, and ANSI test fails here because `time` is a reserved keyword.
We probably need a separate PR for this bug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-724029339
**[Test build #130790 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130790/testReport)** for PR 30299 at commit [`ad9d6d2`](https://github.com/apache/spark/commit/ad9d6d2e8b99805ce04373bed3ff3fa33f5503c3).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-725269907
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130913/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-725455300
**[Test build #130940 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130940/testReport)** for PR 30299 at commit [`6dbd559`](https://github.com/apache/spark/commit/6dbd5595fa0be27ab95caf572b7eb00a50b29d68).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-727814224
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35742/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-724639439
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35464/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gatorsmile commented on a change in pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
gatorsmile commented on a change in pull request #30299:
URL: https://github.com/apache/spark/pull/30299#discussion_r521506018
##########
File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql
##########
@@ -149,7 +149,7 @@ select to_timestamp('2019-10-06 A', 'yyyy-MM-dd GGGGG');
select to_timestamp('22 05 2020 Friday', 'dd MM yyyy EEEEEE');
select to_timestamp('22 05 2020 Friday', 'dd MM yyyy EEEEE');
select unix_timestamp('22 05 2020 Friday', 'dd MM yyyy EEEEE');
-select from_json('{"time":"26/October/2015"}', 'time Timestamp', map('timestampFormat', 'dd/MMMMM/yyyy'));
-select from_json('{"date":"26/October/2015"}', 'date Date', map('dateFormat', 'dd/MMMMM/yyyy'));
-select from_csv('26/October/2015', 'time Timestamp', map('timestampFormat', 'dd/MMMMM/yyyy'));
-select from_csv('26/October/2015', 'date Date', map('dateFormat', 'dd/MMMMM/yyyy'));
+select from_json('{"ts":"26/October/2015"}', 'ts Timestamp', map('timestampFormat', 'dd/MMMMM/yyyy'));
Review comment:
which change caused this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] luluorta commented on a change in pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
luluorta commented on a change in pull request #30299:
URL: https://github.com/apache/spark/pull/30299#discussion_r523940307
##########
File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql
##########
@@ -149,7 +149,7 @@ select to_timestamp('2019-10-06 A', 'yyyy-MM-dd GGGGG');
select to_timestamp('22 05 2020 Friday', 'dd MM yyyy EEEEEE');
select to_timestamp('22 05 2020 Friday', 'dd MM yyyy EEEEE');
select unix_timestamp('22 05 2020 Friday', 'dd MM yyyy EEEEE');
-select from_json('{"time":"26/October/2015"}', 'time Timestamp', map('timestampFormat', 'dd/MMMMM/yyyy'));
-select from_json('{"date":"26/October/2015"}', 'date Date', map('dateFormat', 'dd/MMMMM/yyyy'));
-select from_csv('26/October/2015', 'time Timestamp', map('timestampFormat', 'dd/MMMMM/yyyy'));
-select from_csv('26/October/2015', 'date Date', map('dateFormat', 'dd/MMMMM/yyyy'));
+select from_json('{"ts":"26/October/2015"}', 'ts Timestamp', map('timestampFormat', 'dd/MMMMM/yyyy'));
Review comment:
I opened a new PR for this issue
[https://github.com/apache/spark/pull/30357](https://github.com/apache/spark/pull/30357)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-724441706
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-724577269
**[Test build #130857 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130857/testReport)** for PR 30299 at commit [`b5366df`](https://github.com/apache/spark/commit/b5366df94eeaf00ec41c40a38bcf9105f836ec1b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #30299:
URL: https://github.com/apache/spark/pull/30299#discussion_r520577201
##########
File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql
##########
@@ -149,7 +149,7 @@ select to_timestamp('2019-10-06 A', 'yyyy-MM-dd GGGGG');
select to_timestamp('22 05 2020 Friday', 'dd MM yyyy EEEEEE');
select to_timestamp('22 05 2020 Friday', 'dd MM yyyy EEEEE');
select unix_timestamp('22 05 2020 Friday', 'dd MM yyyy EEEEE');
-select from_json('{"time":"26/October/2015"}', 'time Timestamp', map('timestampFormat', 'dd/MMMMM/yyyy'));
+select from_json('{"timestamp":"26/October/2015"}', 'timestamp Timestamp', map('timestampFormat', 'dd/MMMMM/yyyy'));
Review comment:
why do we change this test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-727809703
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131139/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-724413556
**[Test build #130824 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130824/testReport)** for PR 30299 at commit [`f33d4be`](https://github.com/apache/spark/commit/f33d4be16f8e487b82bd172384778d2e5f4b3a0f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] luluorta commented on a change in pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
luluorta commented on a change in pull request #30299:
URL: https://github.com/apache/spark/pull/30299#discussion_r523954546
##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveTableScanExec.scala
##########
@@ -172,7 +172,7 @@ case class HiveTableScanExec(
prunePartitions(hivePartitions)
}
} else {
- if (sparkSession.sessionState.conf.metastorePartitionPruning &&
Review comment:
Reverted
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-725269550
**[Test build #130913 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130913/testReport)** for PR 30299 at commit [`7047924`](https://github.com/apache/spark/commit/70479247efe6a6b4b3e4d653281ce3a4ea8c5224).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-728080132
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-724034298
**[Test build #130790 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130790/testReport)** for PR 30299 at commit [`ad9d6d2`](https://github.com/apache/spark/commit/ad9d6d2e8b99805ce04373bed3ff3fa33f5503c3).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `trait HasConf `
* `class Analyzer(override val catalogManager: CatalogManager)`
* `class AstBuilder extends SqlBaseBaseVisitor[AnyRef] with Logging with HasConf `
* `abstract class AbstractSqlParser extends ParserInterface with Logging with HasConf `
* `class CatalystSqlParser extends AbstractSqlParser `
* `abstract class QueryPlan[PlanType <: QueryPlan[PlanType]] extends TreeNode[PlanType] with HasConf `
* `abstract class Rule[TreeType <: TreeNode[_]] extends HasConf with Logging `
* `class SparkPlanner(val session: SparkSession, val experimentalMethods: ExperimentalMethods)`
* `class SparkSqlParser extends AbstractSqlParser `
* `class SparkSqlAstBuilder extends AstBuilder `
* `class V2SessionCatalog(catalog: SessionCatalog)`
* `class VariableSubstitution extends HasConf `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-725455300
**[Test build #130940 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130940/testReport)** for PR 30299 at commit [`6dbd559`](https://github.com/apache/spark/commit/6dbd5595fa0be27ab95caf572b7eb00a50b29d68).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #30299:
URL: https://github.com/apache/spark/pull/30299#discussion_r520570386
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/BooleanSimplificationSuite.scala
##########
@@ -188,27 +188,29 @@ class BooleanSimplificationSuite extends PlanTest with ExpressionEvalHelper with
checkCondition(!(('e || 'f) && ('g || 'h)), (!'e && !'f) || (!'g && !'h))
}
- private val caseInsensitiveConf = new SQLConf().copy(SQLConf.CASE_SENSITIVE -> false)
- private val caseInsensitiveAnalyzer = new Analyzer(
- new SessionCatalog(new InMemoryCatalog, EmptyFunctionRegistry, caseInsensitiveConf),
- caseInsensitiveConf)
+ private val analyzer = new Analyzer(
+ new SessionCatalog(new InMemoryCatalog, EmptyFunctionRegistry))
test("(a && b) || (a && c) => a && (b || c) when case insensitive") {
- val plan = caseInsensitiveAnalyzer.execute(
- testRelation.where(('a > 2 && 'b > 3) || ('A > 2 && 'b < 5)))
- val actual = Optimize.execute(plan)
- val expected = caseInsensitiveAnalyzer.execute(
- testRelation.where('a > 2 && ('b > 3 || 'b < 5)))
- comparePlans(actual, expected)
+ withSQLConf(SQLConf.CASE_SENSITIVE.key -> "false") {
+ val plan = analyzer.execute(
+ testRelation.where(('a > 2 && 'b > 3) || ('A > 2 && 'b < 5)))
+ val actual = Optimize.execute(plan)
+ val expected = analyzer.execute(
+ testRelation.where('a > 2 && ('b > 3 || 'b < 5)))
+ comparePlans(actual, expected)
+ }
}
test("(a || b) && (a || c) => a || (b && c) when case insensitive") {
- val plan = caseInsensitiveAnalyzer.execute(
- testRelation.where(('a > 2 || 'b > 3) && ('A > 2 || 'b < 5)))
- val actual = Optimize.execute(plan)
- val expected = caseInsensitiveAnalyzer.execute(
- testRelation.where('a > 2 || ('b > 3 && 'b < 5)))
- comparePlans(actual, expected)
+ withSQLConf(SQLConf.CASE_SENSITIVE.key -> "false") {
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] luluorta commented on a change in pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
luluorta commented on a change in pull request #30299:
URL: https://github.com/apache/spark/pull/30299#discussion_r521134961
##########
File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql
##########
@@ -149,7 +149,7 @@ select to_timestamp('2019-10-06 A', 'yyyy-MM-dd GGGGG');
select to_timestamp('22 05 2020 Friday', 'dd MM yyyy EEEEEE');
select to_timestamp('22 05 2020 Friday', 'dd MM yyyy EEEEE');
select unix_timestamp('22 05 2020 Friday', 'dd MM yyyy EEEEE');
-select from_json('{"time":"26/October/2015"}', 'time Timestamp', map('timestampFormat', 'dd/MMMMM/yyyy'));
+select from_json('{"timestamp":"26/October/2015"}', 'timestamp Timestamp', map('timestampFormat', 'dd/MMMMM/yyyy'));
Review comment:
After this PR, dynamically set "spark.sql.ansi.enabled" actually takes effect in parsing phase. This query will fails parsing cause `time` is a reserved key word of SQL standard.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-725494793
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #30299:
URL: https://github.com/apache/spark/pull/30299#discussion_r520570072
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/BooleanSimplificationSuite.scala
##########
@@ -188,27 +188,29 @@ class BooleanSimplificationSuite extends PlanTest with ExpressionEvalHelper with
checkCondition(!(('e || 'f) && ('g || 'h)), (!'e && !'f) || (!'g && !'h))
}
- private val caseInsensitiveConf = new SQLConf().copy(SQLConf.CASE_SENSITIVE -> false)
- private val caseInsensitiveAnalyzer = new Analyzer(
- new SessionCatalog(new InMemoryCatalog, EmptyFunctionRegistry, caseInsensitiveConf),
- caseInsensitiveConf)
+ private val analyzer = new Analyzer(
+ new SessionCatalog(new InMemoryCatalog, EmptyFunctionRegistry))
test("(a && b) || (a && c) => a && (b || c) when case insensitive") {
- val plan = caseInsensitiveAnalyzer.execute(
- testRelation.where(('a > 2 && 'b > 3) || ('A > 2 && 'b < 5)))
- val actual = Optimize.execute(plan)
- val expected = caseInsensitiveAnalyzer.execute(
- testRelation.where('a > 2 && ('b > 3 || 'b < 5)))
- comparePlans(actual, expected)
+ withSQLConf(SQLConf.CASE_SENSITIVE.key -> "false") {
Review comment:
This is the default value. Seems we can remove `withSQLConf`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-725399735
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35534/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] luluorta commented on a change in pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
luluorta commented on a change in pull request #30299:
URL: https://github.com/apache/spark/pull/30299#discussion_r521396224
##########
File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql
##########
@@ -149,7 +149,7 @@ select to_timestamp('2019-10-06 A', 'yyyy-MM-dd GGGGG');
select to_timestamp('22 05 2020 Friday', 'dd MM yyyy EEEEEE');
select to_timestamp('22 05 2020 Friday', 'dd MM yyyy EEEEE');
select unix_timestamp('22 05 2020 Friday', 'dd MM yyyy EEEEE');
-select from_json('{"time":"26/October/2015"}', 'time Timestamp', map('timestampFormat', 'dd/MMMMM/yyyy'));
+select from_json('{"timestamp":"26/October/2015"}', 'timestamp Timestamp', map('timestampFormat', 'dd/MMMMM/yyyy'));
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-728229716
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-724535635
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-724430632
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-727959591
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-724039343
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35399/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-725269902
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #30299:
URL: https://github.com/apache/spark/pull/30299#discussion_r520564463
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/HasConf.scala
##########
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.catalyst
+
+import org.apache.spark.sql.internal.SQLConf
+
+/**
+ * Trait for shared SQLConf.
+ */
+trait HasConf {
Review comment:
This name is weird. How about `SQLConfHelper`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-725303015
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-724039324
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-727809573
**[Test build #131139 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131139/testReport)** for PR 30299 at commit [`bf1e56a`](https://github.com/apache/spark/commit/bf1e56a87d662b9657e5f46380628b06b9c9e359).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `trait SQLConfHelper `
* `class Analyzer(override val catalogManager: CatalogManager)`
* `class AstBuilder extends SqlBaseBaseVisitor[AnyRef] with SQLConfHelper with Logging `
* `abstract class AbstractSqlParser extends ParserInterface with SQLConfHelper with Logging `
* `abstract class Rule[TreeType <: TreeNode[_]] extends SQLConfHelper with Logging `
* `class SparkPlanner(val session: SparkSession, val experimentalMethods: ExperimentalMethods)`
* `class V2SessionCatalog(catalog: SessionCatalog)`
* `class VariableSubstitution extends SQLConfHelper `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #30299:
URL: https://github.com/apache/spark/pull/30299#discussion_r520564738
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/HasConf.scala
##########
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.catalyst
+
+import org.apache.spark.sql.internal.SQLConf
+
+/**
+ * Trait for shared SQLConf.
Review comment:
`Trait for getting the active SQLConf.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-727828610
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-724649337
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35464/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] luluorta commented on a change in pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
luluorta commented on a change in pull request #30299:
URL: https://github.com/apache/spark/pull/30299#discussion_r521143561
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/BooleanSimplificationSuite.scala
##########
@@ -188,27 +188,29 @@ class BooleanSimplificationSuite extends PlanTest with ExpressionEvalHelper with
checkCondition(!(('e || 'f) && ('g || 'h)), (!'e && !'f) || (!'g && !'h))
}
- private val caseInsensitiveConf = new SQLConf().copy(SQLConf.CASE_SENSITIVE -> false)
- private val caseInsensitiveAnalyzer = new Analyzer(
- new SessionCatalog(new InMemoryCatalog, EmptyFunctionRegistry, caseInsensitiveConf),
- caseInsensitiveConf)
+ private val analyzer = new Analyzer(
+ new SessionCatalog(new InMemoryCatalog, EmptyFunctionRegistry))
test("(a && b) || (a && c) => a && (b || c) when case insensitive") {
- val plan = caseInsensitiveAnalyzer.execute(
- testRelation.where(('a > 2 && 'b > 3) || ('A > 2 && 'b < 5)))
- val actual = Optimize.execute(plan)
- val expected = caseInsensitiveAnalyzer.execute(
- testRelation.where('a > 2 && ('b > 3 || 'b < 5)))
- comparePlans(actual, expected)
+ withSQLConf(SQLConf.CASE_SENSITIVE.key -> "false") {
+ val plan = analyzer.execute(
+ testRelation.where(('a > 2 && 'b > 3) || ('A > 2 && 'b < 5)))
+ val actual = Optimize.execute(plan)
+ val expected = analyzer.execute(
+ testRelation.where('a > 2 && ('b > 3 || 'b < 5)))
+ comparePlans(actual, expected)
+ }
}
test("(a || b) && (a || c) => a || (b && c) when case insensitive") {
- val plan = caseInsensitiveAnalyzer.execute(
- testRelation.where(('a > 2 || 'b > 3) && ('A > 2 || 'b < 5)))
- val actual = Optimize.execute(plan)
- val expected = caseInsensitiveAnalyzer.execute(
- testRelation.where('a > 2 || ('b > 3 && 'b < 5)))
- comparePlans(actual, expected)
+ withSQLConf(SQLConf.CASE_SENSITIVE.key -> "false") {
Review comment:
reverted
##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveTableScanExec.scala
##########
@@ -60,8 +59,6 @@ case class HiveTableScanExec(
require(partitionPruningPred.isEmpty || relation.isPartitioned,
"Partition pruning predicates only supported for partitioned tables.")
- override def conf: SQLConf = sparkSession.sessionState.conf
Review comment:
reverted
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-724441706
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-725318429
**[Test build #130929 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130929/testReport)** for PR 30299 at commit [`ce97a61`](https://github.com/apache/spark/commit/ce97a61d904e2a5a37bc65168ed8773a685c5bf6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-724577269
**[Test build #130857 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130857/testReport)** for PR 30299 at commit [`b5366df`](https://github.com/apache/spark/commit/b5366df94eeaf00ec41c40a38bcf9105f836ec1b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-727810438
**[Test build #131141 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131141/testReport)** for PR 30299 at commit [`0cc0b42`](https://github.com/apache/spark/commit/0cc0b426f4b0dd0b66fcf0b4c606dcdfe6d08941).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-724409093
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-725302981
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35519/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #30299:
URL: https://github.com/apache/spark/pull/30299
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-727846909
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-727846882
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35744/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-724649354
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-727961889
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-724409093
**[Test build #130821 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130821/testReport)** for PR 30299 at commit [`90181f9`](https://github.com/apache/spark/commit/90181f9e8400764e78b5e518bcc8c4add5f5e80b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-725494764
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35545/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-727959594
**[Test build #131159 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131159/testReport)** for PR 30299 at commit [`99619e3`](https://github.com/apache/spark/commit/99619e3f0d2596f2777df6859f2f61a3c90d1d3c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #30299:
URL: https://github.com/apache/spark/pull/30299#discussion_r520566520
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
##########
@@ -61,34 +61,38 @@ class SessionCatalog(
externalCatalogBuilder: () => ExternalCatalog,
globalTempViewManagerBuilder: () => GlobalTempViewManager,
functionRegistry: FunctionRegistry,
- conf: SQLConf,
hadoopConf: Configuration,
parser: ParserInterface,
- functionResourceLoader: FunctionResourceLoader) extends Logging {
+ functionResourceLoader: FunctionResourceLoader,
+ cacheSize: Int = SQLConf.get.tableRelationCacheSize,
+ cacheTTL: Long = SQLConf.get.metadataCacheTTL) extends Logging with HasConf {
import SessionCatalog._
import CatalogTypes.TablePartitionSpec
// For testing only.
def this(
externalCatalog: ExternalCatalog,
functionRegistry: FunctionRegistry,
- conf: SQLConf) = {
+ staticConf: SQLConf) = {
Review comment:
The previous name `conf` is OK. `SQLConf` contains both static and runtime configs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-727791622
**[Test build #131139 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131139/testReport)** for PR 30299 at commit [`bf1e56a`](https://github.com/apache/spark/commit/bf1e56a87d662b9657e5f46380628b06b9c9e359).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-724034331
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-725462281
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-727828610
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-724630363
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] luluorta commented on a change in pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
luluorta commented on a change in pull request #30299:
URL: https://github.com/apache/spark/pull/30299#discussion_r521143263
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/BooleanSimplificationSuite.scala
##########
@@ -188,27 +188,29 @@ class BooleanSimplificationSuite extends PlanTest with ExpressionEvalHelper with
checkCondition(!(('e || 'f) && ('g || 'h)), (!'e && !'f) || (!'g && !'h))
}
- private val caseInsensitiveConf = new SQLConf().copy(SQLConf.CASE_SENSITIVE -> false)
- private val caseInsensitiveAnalyzer = new Analyzer(
- new SessionCatalog(new InMemoryCatalog, EmptyFunctionRegistry, caseInsensitiveConf),
- caseInsensitiveConf)
+ private val analyzer = new Analyzer(
+ new SessionCatalog(new InMemoryCatalog, EmptyFunctionRegistry))
test("(a && b) || (a && c) => a && (b || c) when case insensitive") {
- val plan = caseInsensitiveAnalyzer.execute(
- testRelation.where(('a > 2 && 'b > 3) || ('A > 2 && 'b < 5)))
- val actual = Optimize.execute(plan)
- val expected = caseInsensitiveAnalyzer.execute(
- testRelation.where('a > 2 && ('b > 3 || 'b < 5)))
- comparePlans(actual, expected)
+ withSQLConf(SQLConf.CASE_SENSITIVE.key -> "false") {
Review comment:
reverted
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-727810438
**[Test build #131141 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131141/testReport)** for PR 30299 at commit [`0cc0b42`](https://github.com/apache/spark/commit/0cc0b426f4b0dd0b66fcf0b4c606dcdfe6d08941).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-725303015
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-725318429
**[Test build #130929 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130929/testReport)** for PR 30299 at commit [`ce97a61`](https://github.com/apache/spark/commit/ce97a61d904e2a5a37bc65168ed8773a685c5bf6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-725269902
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-725494793
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-724649354
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-725399747
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-724034335
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130790/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-725616384
**[Test build #130940 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130940/testReport)** for PR 30299 at commit [`6dbd559`](https://github.com/apache/spark/commit/6dbd5595fa0be27ab95caf572b7eb00a50b29d68).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-728080061
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35762/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-724430632
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-724435500
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35432/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #30299:
URL: https://github.com/apache/spark/pull/30299#discussion_r523944573
##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveTableScanExec.scala
##########
@@ -172,7 +172,7 @@ case class HiveTableScanExec(
prunePartitions(hivePartitions)
}
} else {
- if (sparkSession.sessionState.conf.metastorePartitionPruning &&
Review comment:
let's keep this unchanged for now. We may override `def conf` in `SparkPlan` later, to always get conf from the captured spark session.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-728229716
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-725249564
**[Test build #130913 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130913/testReport)** for PR 30299 at commit [`7047924`](https://github.com/apache/spark/commit/70479247efe6a6b4b3e4d653281ce3a4ea8c5224).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-727961889
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] luluorta commented on a change in pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
luluorta commented on a change in pull request #30299:
URL: https://github.com/apache/spark/pull/30299#discussion_r523940307
##########
File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql
##########
@@ -149,7 +149,7 @@ select to_timestamp('2019-10-06 A', 'yyyy-MM-dd GGGGG');
select to_timestamp('22 05 2020 Friday', 'dd MM yyyy EEEEEE');
select to_timestamp('22 05 2020 Friday', 'dd MM yyyy EEEEE');
select unix_timestamp('22 05 2020 Friday', 'dd MM yyyy EEEEE');
-select from_json('{"time":"26/October/2015"}', 'time Timestamp', map('timestampFormat', 'dd/MMMMM/yyyy'));
-select from_json('{"date":"26/October/2015"}', 'date Date', map('dateFormat', 'dd/MMMMM/yyyy'));
-select from_csv('26/October/2015', 'time Timestamp', map('timestampFormat', 'dd/MMMMM/yyyy'));
-select from_csv('26/October/2015', 'date Date', map('dateFormat', 'dd/MMMMM/yyyy'));
+select from_json('{"ts":"26/October/2015"}', 'ts Timestamp', map('timestampFormat', 'dd/MMMMM/yyyy'));
Review comment:
I opened a new PR for this issue
[https://github.com/apache/spark/pull/30357](url)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] luluorta commented on a change in pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
luluorta commented on a change in pull request #30299:
URL: https://github.com/apache/spark/pull/30299#discussion_r521142283
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
##########
@@ -61,34 +61,38 @@ class SessionCatalog(
externalCatalogBuilder: () => ExternalCatalog,
globalTempViewManagerBuilder: () => GlobalTempViewManager,
functionRegistry: FunctionRegistry,
- conf: SQLConf,
hadoopConf: Configuration,
parser: ParserInterface,
- functionResourceLoader: FunctionResourceLoader) extends Logging {
+ functionResourceLoader: FunctionResourceLoader,
+ cacheSize: Int = SQLConf.get.tableRelationCacheSize,
+ cacheTTL: Long = SQLConf.get.metadataCacheTTL) extends Logging with HasConf {
import SessionCatalog._
import CatalogTypes.TablePartitionSpec
// For testing only.
def this(
externalCatalog: ExternalCatalog,
functionRegistry: FunctionRegistry,
- conf: SQLConf) = {
+ staticConf: SQLConf) = {
Review comment:
reverted
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30299:
URL: https://github.com/apache/spark/pull/30299#issuecomment-728228508
**[Test build #131159 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131159/testReport)** for PR 30299 at commit [`99619e3`](https://github.com/apache/spark/commit/99619e3f0d2596f2777df6859f2f61a3c90d1d3c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org