[GitHub] [incubator-daffodil] stevedlawrence commented on issue #265: Add blob support

[GitBox <gi...@apache.org>]

stevedlawrence commented on issue #265: Add blob support
URL: https://github.com/apache/incubator-daffodil/pull/265#issuecomment-525740272
 
 
   I've just pushed changes that rename the function, and also fixes a integer overflow issue when converting the explicit length long to an int. With that fix, I am able to parse a 3.4GB bmp file. I'm a little concerned we have other places doing an unsafe .toInt call.
   
   I also tested on unparse, and ran into an out of memory error in the BufferedDataOutputStream. I think the issue there is it's backed by a BuferredArray, whcih has a limit of 2GB. We probably need to split buffered data output streams when they reach 2GB. But that's unrelated to the blob feature. I'll create a bug for that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services