[jira] [Commented] (AIRFLOW-5825) SageMakerEndpointOperator is not idempotent

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-5825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17068008#comment-17068008 ] 

ASF GitHub Bot commented on AIRFLOW-5825:
-----------------------------------------

OmairK commented on pull request #7891: [AIRFLOW-5825] SageMakerEndpointOperator is not idempotent
URL: https://github.com/apache/airflow/pull/7891
 
 
   	- Added try except statement to check for duplicate endpoint while executing a create_endpoint request  which if found the request changes to update_endpoint
   	- Added test case to test mock the duplicate endpoint creation
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> SageMakerEndpointOperator is not idempotent
> -------------------------------------------
>
>                 Key: AIRFLOW-5825
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5825
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: aws
>    Affects Versions: 2.0.0, 1.10.7
>            Reporter: Bas Harenslak
>            Assignee: Omair Khan
>            Priority: Major
>              Labels: gsoc, gsoc2020, mentor
>
> The SageMakerEndpointOperator currently taken an argument "operati on" with value "create"/"update" which determines whether to create or update a SageMaker endpoint. However this doesn't work in the following situation:
>  * DAG run #1 create the endpoint (have to provide operation="create" here)
>  * Following DAG runs will update the endpoint created by DAG run #1 (would have to edit DAG and set operation="update" here)
> Which should be a very valid use case IMO.
> The SageMakerEndpointOperator should check itself if an endpoint with name X already exists and overwrite it (configurable desired by the user).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)