[GitHub] [incubator-nuttx] yamt commented on pull request #2482: Syslog format, nxstyle fixes, remove non-ascii characters

[GitBox <gi...@apache.org>]

yamt commented on pull request #2482:
URL: https://github.com/apache/incubator-nuttx/pull/2482#issuecomment-739247815


   nxstyle errors in drivers/video/ov2640.c are left because i'm not sure
   how they should be fixed.
   These are initializers like:
       
         {0xff, 0x00},  {0x2c, 0xff},  {0x2e, 0xdf},  {0xff, 0x01},  {0x3c, 0x32},
         {0x11, 0x00},  {0x09, 0x02},  {0x04, 0x28},  {0x13, 0xe5},  {0x14, 0x48},
         {0x2c, 0x0c},  {0x33, 0x78},  {0x3a, 0x33},  {0x3b, 0xfb},  {0x3e, 0x00},
         {0x43, 0x11},  {0x16, 0x10},  {0x39, 0x02},  {0x35, 0x88},  {0x22, 0x0a},
       
        drivers/video/ov2640.c:309:16: error: Left bracket not on separate line
   
   The following nxstyle errors are not trivial to fix because
   they are parts of the ioctl api.
       
       drivers/wireless/ieee80211/bcm43xxx/bcmf_driver.c:1083:34: error: Mixed case identifier found
       drivers/wireless/ieee80211/bcm43xxx/bcmf_driver.c:1445:7: error: Mixed case identifier found
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org