You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/05/11 16:38:39 UTC
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6033: NIFI-10014 Upgrade Registry Test JDBC Drivers
exceptionfactory commented on code in PR #6033:
URL: https://github.com/apache/nifi/pull/6033#discussion_r870532108
##########
README.md:
##########
@@ -281,30 +281,11 @@ If no profile is specified then an H2 DataSource will be used by default and no
Assuming Docker is running on the system where the build is running, then the following commands can be run:
| Target Database | Build Command |
-| --------------- | ------------- |
-| All supported | `mvn verify -Ptest-all-dbs` |
-| H2 (default) | `mvn verify` |
-| PostgreSQL 9.x | `mvn verify -Dspring.profiles.active=postgres` |
-| PostgreSQL 10.x | `mvn verify -Dspring.profiles.active=postgres-10` |
-| MySQL 5.6 | `mvn verify -Pcontrib-check -Dspring.profiles.active=mysql-56` |
-| MySQL 5.7 | `mvn verify -Pcontrib-check -Dspring.profiles.active=mysql-57` |
-| MySQL 8 | `mvn verify -Pcontrib-check -Dspring.profiles.active=mysql-8` |
-
- When one of the Testcontainer profiles is activated, the test output should show logs that indicate a container has been started, such as the following:
-
- 2019-05-15 16:14:45.078 INFO 66091 --- [ main] 🐳 [mysql:5.7] : Creating container for image: mysql:5.7
- 2019-05-15 16:14:45.145 INFO 66091 --- [ main] o.t.utility.RegistryAuthLocator : Credentials not found for host (index.docker.io) when using credential helper/store (docker-credential-osxkeychain)
- 2019-05-15 16:14:45.646 INFO 66091 --- [ main] 🐳 [mysql:5.7] : Starting container with ID: ca85c8c5a1990d2a898fad04c5897ddcdb3a9405e695cc11259f50f2ebe67c5f
- 2019-05-15 16:14:46.437 INFO 66091 --- [ main] 🐳 [mysql:5.7] : Container mysql:5.7 is starting: ca85c8c5a1990d2a898fad04c5897ddcdb3a9405e695cc11259f50f2ebe67c5f
- 2019-05-15 16:14:46.479 INFO 66091 --- [ main] 🐳 [mysql:5.7] : Waiting for database connection to become available at jdbc:mysql://localhost:33051/test?useSSL=false&allowPublicKeyRetrieval=true using query 'SELECT 1'
-
-The Flyway connection should also indicate the given database:
-
- 2019-05-15 16:15:02.114 INFO 66091 --- [ main] o.a.n.r.db.CustomFlywayConfiguration : Determined database type is MYSQL
- 2019-05-15 16:15:02.115 INFO 66091 --- [ main] o.a.n.r.db.CustomFlywayConfiguration : Setting migration locations to [classpath:db/migration/common, classpath:db/migration/mysql]
- 2019-05-15 16:15:02.373 INFO 66091 --- [ main] o.a.n.r.d.CustomFlywayMigrationStrategy : First time initializing database...
- 2019-05-15 16:15:02.380 INFO 66091 --- [ main] o.f.c.internal.license.VersionPrinter : Flyway Community Edition 5.2.1 by Boxfuse
- 2019-05-15 16:15:02.403 INFO 66091 --- [ main] o.f.c.internal.database.DatabaseFactory : Database: jdbc:mysql://localhost:33051/test (MySQL 5.7)
+| ------------- | ------------- |
+| All supported | `mvn verify -Ptest-all-dbs` |
+| H2 (default) | `mvn verify` |
+| PostgreSQL 10 | `mvn verify -Dspring.profiles.active=postgres-10` |
+| MySQL 8 | `mvn verify -Pcontrib-check -Dspring.profiles.active=mysql-8` |
Review Comment:
> shouldn't we also have a MariaDB option here?
The sentence following the table reads:
> For a full list of the available DataSource factories, consult the `nifi-registry-test` module.
So I could add a line for MariaDB if that seems useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org