You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by iyovcheva <no...@github.com> on 2016/08/09 13:37:12 UTC

[jclouds/jclouds] Fix for ssh reload for Centos 7 (#992)

You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/992

-- Commit Summary --

  * Fix for ssh reload for Centos 7

-- File Changes --

    M scriptbuilder/src/main/java/org/jclouds/scriptbuilder/statements/ssh/SshdConfig.java (2)
    M scriptbuilder/src/test/java/org/jclouds/scriptbuilder/statements/ssh/SshStatementsTest.java (4)
    M scriptbuilder/src/test/resources/test_adminaccess_params.sh (2)
    M scriptbuilder/src/test/resources/test_adminaccess_params_and_fullname.sh (2)
    M scriptbuilder/src/test/resources/test_adminaccess_standard.sh (2)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/992.patch
https://github.com/jclouds/jclouds/pull/992.diff

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/992

Re: [jclouds/jclouds] Fix for ssh reload for CentOS 7 (#992)

Posted by Ignasi Barrera <no...@github.com>.

Thanks @iyovcheva!
Unfortunately it looks like our CI system only runs the unit tests and not the integration ones. When running a build locally (with `mvn clean install`) I get these failures in jclouds-compute:

    Tests run: 40, Failures: 3, Errors: 0, Skipped: 11
    testCreateAndRunAService(org.jclouds.compute.StubComputeServiceIntegrationTest)
    testAScriptExecutionAfterBootWithBasicTemplate(org.jclouds.compute.StubComputeServiceIntegrationTest)
    testCreateTwoNodesWithRunScript(org.jclouds.compute.StubComputeServiceIntegrationTest)

Could you run a build locally and have a look at those tests?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/992#issuecomment-239172044

Re: [jclouds/jclouds] Fix for ssh reload for CentOS 7 (#992)

Posted by Ignasi Barrera <no...@github.com>.

Closed #992.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/992#event-756327947

Re: [jclouds/jclouds] Fix for ssh reload for CentOS 7 (#992)

Posted by Ignasi Barrera <no...@github.com>.

Pushed to master as [cf5a66ab](http://git-wip-us.apache.org/repos/asf/jclouds/commit/cf5a66ab). Thanks @iyovcheva!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/992#issuecomment-239955490