You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/09/22 03:15:30 UTC

[GitHub] rdhabalia opened a new pull request #2636: Fix: NPE if messageId not present on create-sub admin-api call

rdhabalia opened a new pull request #2636: Fix: NPE if messageId not present on create-sub admin-api call
URL: https://github.com/apache/pulsar/pull/2636
 
 
   ### Motivation
   
   Right now, while creating subscription if user doesn't pass message-id then broker doesn't handle it properly which gives NPE and gives internal-server error to user.
   
   ```
   Message: null
   
   Stacktrace:
   
   java.lang.NullPointerException
           at org.apache.pulsar.broker.admin.PersistentTopics.createSubscription(PersistentTopics.java:885)
           at sun.reflect.GeneratedMethodAccessor199.invoke(Unknown Source)
   ```
   
   ### Modifications
   
   - take earliest-message id while creating subscription if user doesn't provide message-id.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services