You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pagespeed.apache.org by GitBox <gi...@apache.org> on 2018/04/05 21:04:44 UTC

[GitHub] Enalmada commented on issue #1760: ModPagespeedAddResourceHeader Access-Control-Allow-Origin duplicate headers

Enalmada commented on issue #1760: ModPagespeedAddResourceHeader Access-Control-Allow-Origin duplicate headers
URL: https://github.com/apache/incubator-pagespeed-mod/issues/1760#issuecomment-379076382
 
 
   I figured duplicate headers would never be desirable and the lookup would be the most practical solution but if there is a case that people would actually use Add instead of Set then that seems low risk. 
   
   BTW The setifempty workaround seemed fine for a week and then I noticed just one image with no cors header set.  The image was set through ModPagespeedMapProxyDomain
   `ModPagespeedMapProxyDomain http://www.myserver.com/images/ https://unoptimizedS3bucket/images/ https://mycdn.cloudfront.net/images/`
   ...so perhaps ModPagespeedMapProxyDomain can skip the setifempty if it is coming out of cache somehow?   
   
   Anyway, thank you very much for looking into this!  
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services