You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Andrei Dragomir (JIRA)" <ji...@apache.org> on 2010/01/26 22:18:34 UTC
[jira] Created: (THRIFT-693) Thrift compiler generated java code
that throws compiler warnings about deprecated methods.
Thrift compiler generated java code that throws compiler warnings about deprecated methods.
--------------------------------------------------------------------------------------------
Key: THRIFT-693
URL: https://issues.apache.org/jira/browse/THRIFT-693
Project: Thrift
Issue Type: Bug
Components: Compiler (C++), Library (Java)
Affects Versions: 0.2
Reporter: Andrei Dragomir
Installed release thrift-0.2.0. The compiler generates java code with the methods setFieldValue, getFieldValue and isSet. However, in the TBase interface, these methods are marked as deprecated. This throws java compiler warnings when compiling the thrift generated library code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-693) Thrift compiler generated java code
that throws compiler warnings about deprecated methods.
Posted by "Andrei Dragomir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805221#action_12805221 ]
Andrei Dragomir commented on THRIFT-693:
----------------------------------------
Would it be useful to look at making a thrift compiler patch that removes these methods from the generated code then ?
(Explanation: we set up out automatic build system to fail the build when there are javac warnings, and this is playing havoc with our builds)
> Thrift compiler generated java code that throws compiler warnings about deprecated methods.
> --------------------------------------------------------------------------------------------
>
> Key: THRIFT-693
> URL: https://issues.apache.org/jira/browse/THRIFT-693
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (C++), Library (Java)
> Affects Versions: 0.2
> Reporter: Andrei Dragomir
>
> Installed release thrift-0.2.0. The compiler generates java code with the methods setFieldValue, getFieldValue and isSet. However, in the TBase interface, these methods are marked as deprecated. This throws java compiler warnings when compiling the thrift generated library code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-693) Thrift compiler generated java code
that throws compiler warnings about deprecated methods.
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805246#action_12805246 ]
David Reiss commented on THRIFT-693:
------------------------------------
Yeah. We could also have a generator option (similar to nocamel) that disables the generation of these methods.
> Thrift compiler generated java code that throws compiler warnings about deprecated methods.
> --------------------------------------------------------------------------------------------
>
> Key: THRIFT-693
> URL: https://issues.apache.org/jira/browse/THRIFT-693
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (C++), Library (Java)
> Affects Versions: 0.2
> Reporter: Andrei Dragomir
>
> Installed release thrift-0.2.0. The compiler generates java code with the methods setFieldValue, getFieldValue and isSet. However, in the TBase interface, these methods are marked as deprecated. This throws java compiler warnings when compiling the thrift generated library code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-693) Thrift compiler generated java code
that throws compiler warnings about deprecated methods.
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805211#action_12805211 ]
Bryan Duxbury commented on THRIFT-693:
--------------------------------------
These methods were kept for backwards compatibility reasons, and will be removed in a future release.
> Thrift compiler generated java code that throws compiler warnings about deprecated methods.
> --------------------------------------------------------------------------------------------
>
> Key: THRIFT-693
> URL: https://issues.apache.org/jira/browse/THRIFT-693
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (C++), Library (Java)
> Affects Versions: 0.2
> Reporter: Andrei Dragomir
>
> Installed release thrift-0.2.0. The compiler generates java code with the methods setFieldValue, getFieldValue and isSet. However, in the TBase interface, these methods are marked as deprecated. This throws java compiler warnings when compiling the thrift generated library code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-693) Thrift compiler generated java code
that throws compiler warnings about deprecated methods.
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-693:
---------------------------------
Attachment: thrift-693.patch
This patch removes the deprecated methods from TBase and makes some generator changes to accommodate.
> Thrift compiler generated java code that throws compiler warnings about deprecated methods.
> --------------------------------------------------------------------------------------------
>
> Key: THRIFT-693
> URL: https://issues.apache.org/jira/browse/THRIFT-693
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Compiler, Java - Library
> Affects Versions: 0.2
> Reporter: Andrei Dragomir
> Attachments: thrift-693.patch
>
>
> Installed release thrift-0.2.0. The compiler generates java code with the methods setFieldValue, getFieldValue and isSet. However, in the TBase interface, these methods are marked as deprecated. This throws java compiler warnings when compiling the thrift generated library code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-693) Thrift compiler generated java code
that throws compiler warnings about deprecated methods.
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-693.
--------------------------------
Assignee: Bryan Duxbury
Fix Version/s: 0.5
Resolution: Fixed
I just committed this.
> Thrift compiler generated java code that throws compiler warnings about deprecated methods.
> --------------------------------------------------------------------------------------------
>
> Key: THRIFT-693
> URL: https://issues.apache.org/jira/browse/THRIFT-693
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Compiler, Java - Library
> Affects Versions: 0.2
> Reporter: Andrei Dragomir
> Assignee: Bryan Duxbury
> Fix For: 0.5
>
> Attachments: thrift-693.patch
>
>
> Installed release thrift-0.2.0. The compiler generates java code with the methods setFieldValue, getFieldValue and isSet. However, in the TBase interface, these methods are marked as deprecated. This throws java compiler warnings when compiling the thrift generated library code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.