You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2016/01/13 07:21:56 UTC

Review Request 42235: Added protobuf for docker ImageReference and the parsing function.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42235/
-----------------------------------------------------------

Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.


Bugs: MESOS-4296
    https://issues.apache.org/jira/browse/MESOS-4296


Repository: mesos


Description
-------

The goal here is to replace Image::Name with ImageReference and the
corresponding parsing method, which will be done in a subsequent patch.


Diffs
-----

  include/mesos/docker/spec.proto PRE-CREATION 
  src/CMakeLists.txt 39a23df3227a4f524ea0d408dc894fa5bbab7d10 
  src/Makefile.am 8cbfb1ba5fa49f2d3cc26ea325838a1c68a79660 
  src/docker/spec.hpp 822b2383c6d6bd691cb1fdbfcd699ae3ae3585bd 
  src/docker/spec.cpp 0188078037b3528acefa42d39f05bd60789b19b2 
  src/slave/containerizer/mesos/provisioner/docker/message.hpp 162e4c689bba832e523ff6b7d4e1e3c8e6713803 
  src/slave/containerizer/mesos/provisioner/docker/message.proto 2b2ed056bd9acd341de0e5cbdb4eed711f3a0fe5 
  src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp bd6dace826b3694748e4209dac5aa73256356f41 
  src/tests/containerizer/docker_spec_tests.cpp aa4faf92e82acd739efc1da15521261da0092afa 
  src/tests/containerizer/provisioner_docker_tests.cpp f81f0039dc12d09d85fda0be345d1509b4c6a664 

Diff: https://reviews.apache.org/r/42235/diff/


Testing
-------

make check


Thanks,

Jie Yu

Re: Review Request 42235: Added protobuf for docker ImageReference and the parsing function.

Posted by Jie Yu <yu...@gmail.com>.

> On Jan. 13, 2016, 6:44 p.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp, lines 23-26
> > <https://reviews.apache.org/r/42235/diff/1/?file=1195235#file1195235line23>
> >
> >     move them under `#include <process/process.hpp>`

This file will be removed later. So I'll punt this for now.


> On Jan. 13, 2016, 6:44 p.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp, line 32
> > <https://reviews.apache.org/r/42235/diff/1/?file=1195235#file1195235line32>
> >
> >     A little cleanup here:
> >     move this header above `#include <process/future.hpp>`

Ditto.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42235/#review114250
-----------------------------------------------------------


On Jan. 13, 2016, 6:21 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42235/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2016, 6:21 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-4296
>     https://issues.apache.org/jira/browse/MESOS-4296
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The goal here is to replace Image::Name with ImageReference and the
> corresponding parsing method, which will be done in a subsequent patch.
> 
> 
> Diffs
> -----
> 
>   include/mesos/docker/spec.proto PRE-CREATION 
>   src/CMakeLists.txt 39a23df3227a4f524ea0d408dc894fa5bbab7d10 
>   src/Makefile.am 8cbfb1ba5fa49f2d3cc26ea325838a1c68a79660 
>   src/docker/spec.hpp 822b2383c6d6bd691cb1fdbfcd699ae3ae3585bd 
>   src/docker/spec.cpp 0188078037b3528acefa42d39f05bd60789b19b2 
>   src/slave/containerizer/mesos/provisioner/docker/message.hpp 162e4c689bba832e523ff6b7d4e1e3c8e6713803 
>   src/slave/containerizer/mesos/provisioner/docker/message.proto 2b2ed056bd9acd341de0e5cbdb4eed711f3a0fe5 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp bd6dace826b3694748e4209dac5aa73256356f41 
>   src/tests/containerizer/docker_spec_tests.cpp aa4faf92e82acd739efc1da15521261da0092afa 
>   src/tests/containerizer/provisioner_docker_tests.cpp f81f0039dc12d09d85fda0be345d1509b4c6a664 
> 
> Diff: https://reviews.apache.org/r/42235/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 42235: Added protobuf for docker ImageReference and the parsing function.

Posted by Jie Yu <yu...@gmail.com>.

> On Jan. 13, 2016, 6:44 p.m., Gilbert Song wrote:
> > src/docker/spec.cpp, line 62
> > <https://reviews.apache.org/r/42235/diff/1/?file=1195232#file1195232line62>
> >
> >     We remove setting default tag as `latest`, is it because not necessary to set (if no tag is specified, it will pull the latest-tagged image)?

Yeah, I think this logic belongs to the caller. The utility function here will just do the parsing.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42235/#review114250
-----------------------------------------------------------


On Jan. 13, 2016, 6:21 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42235/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2016, 6:21 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-4296
>     https://issues.apache.org/jira/browse/MESOS-4296
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The goal here is to replace Image::Name with ImageReference and the
> corresponding parsing method, which will be done in a subsequent patch.
> 
> 
> Diffs
> -----
> 
>   include/mesos/docker/spec.proto PRE-CREATION 
>   src/CMakeLists.txt 39a23df3227a4f524ea0d408dc894fa5bbab7d10 
>   src/Makefile.am 8cbfb1ba5fa49f2d3cc26ea325838a1c68a79660 
>   src/docker/spec.hpp 822b2383c6d6bd691cb1fdbfcd699ae3ae3585bd 
>   src/docker/spec.cpp 0188078037b3528acefa42d39f05bd60789b19b2 
>   src/slave/containerizer/mesos/provisioner/docker/message.hpp 162e4c689bba832e523ff6b7d4e1e3c8e6713803 
>   src/slave/containerizer/mesos/provisioner/docker/message.proto 2b2ed056bd9acd341de0e5cbdb4eed711f3a0fe5 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp bd6dace826b3694748e4209dac5aa73256356f41 
>   src/tests/containerizer/docker_spec_tests.cpp aa4faf92e82acd739efc1da15521261da0092afa 
>   src/tests/containerizer/provisioner_docker_tests.cpp f81f0039dc12d09d85fda0be345d1509b4c6a664 
> 
> Diff: https://reviews.apache.org/r/42235/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 42235: Added protobuf for docker ImageReference and the parsing function.

Posted by Jie Yu <yu...@gmail.com>.

> On Jan. 13, 2016, 6:44 p.m., Gilbert Song wrote:
> > src/tests/containerizer/docker_spec_tests.cpp, line 22
> > <https://reviews.apache.org/r/42235/diff/1/?file=1195236#file1195236line22>
> >
> >     ditto.

We put library headers before mesos headers.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42235/#review114250
-----------------------------------------------------------


On Jan. 13, 2016, 6:21 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42235/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2016, 6:21 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-4296
>     https://issues.apache.org/jira/browse/MESOS-4296
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The goal here is to replace Image::Name with ImageReference and the
> corresponding parsing method, which will be done in a subsequent patch.
> 
> 
> Diffs
> -----
> 
>   include/mesos/docker/spec.proto PRE-CREATION 
>   src/CMakeLists.txt 39a23df3227a4f524ea0d408dc894fa5bbab7d10 
>   src/Makefile.am 8cbfb1ba5fa49f2d3cc26ea325838a1c68a79660 
>   src/docker/spec.hpp 822b2383c6d6bd691cb1fdbfcd699ae3ae3585bd 
>   src/docker/spec.cpp 0188078037b3528acefa42d39f05bd60789b19b2 
>   src/slave/containerizer/mesos/provisioner/docker/message.hpp 162e4c689bba832e523ff6b7d4e1e3c8e6713803 
>   src/slave/containerizer/mesos/provisioner/docker/message.proto 2b2ed056bd9acd341de0e5cbdb4eed711f3a0fe5 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp bd6dace826b3694748e4209dac5aa73256356f41 
>   src/tests/containerizer/docker_spec_tests.cpp aa4faf92e82acd739efc1da15521261da0092afa 
>   src/tests/containerizer/provisioner_docker_tests.cpp f81f0039dc12d09d85fda0be345d1509b4c6a664 
> 
> Diff: https://reviews.apache.org/r/42235/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 42235: Added protobuf for docker ImageReference and the parsing function.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42235/#review114250
-----------------------------------------------------------

Ship it!


Verified that the logic in `parseImageReference` is generally the same as `parseImageName`.


src/docker/spec.cpp (line 62)
<https://reviews.apache.org/r/42235/#comment175054>

    We remove setting default tag as `latest`, is it because not necessary to set (if no tag is specified, it will pull the latest-tagged image)?



src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp (lines 23 - 26)
<https://reviews.apache.org/r/42235/#comment175050>

    move them under `#include <process/process.hpp>`



src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp (line 32)
<https://reviews.apache.org/r/42235/#comment175049>

    A little cleanup here:
    move this header above `#include <process/future.hpp>`



src/tests/containerizer/docker_spec_tests.cpp (line 22)
<https://reviews.apache.org/r/42235/#comment175051>

    ditto.



src/tests/containerizer/provisioner_docker_tests.cpp (line 42)
<https://reviews.apache.org/r/42235/#comment175052>

    ditto.


- Gilbert Song


On Jan. 12, 2016, 10:21 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42235/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2016, 10:21 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-4296
>     https://issues.apache.org/jira/browse/MESOS-4296
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The goal here is to replace Image::Name with ImageReference and the
> corresponding parsing method, which will be done in a subsequent patch.
> 
> 
> Diffs
> -----
> 
>   include/mesos/docker/spec.proto PRE-CREATION 
>   src/CMakeLists.txt 39a23df3227a4f524ea0d408dc894fa5bbab7d10 
>   src/Makefile.am 8cbfb1ba5fa49f2d3cc26ea325838a1c68a79660 
>   src/docker/spec.hpp 822b2383c6d6bd691cb1fdbfcd699ae3ae3585bd 
>   src/docker/spec.cpp 0188078037b3528acefa42d39f05bd60789b19b2 
>   src/slave/containerizer/mesos/provisioner/docker/message.hpp 162e4c689bba832e523ff6b7d4e1e3c8e6713803 
>   src/slave/containerizer/mesos/provisioner/docker/message.proto 2b2ed056bd9acd341de0e5cbdb4eed711f3a0fe5 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp bd6dace826b3694748e4209dac5aa73256356f41 
>   src/tests/containerizer/docker_spec_tests.cpp aa4faf92e82acd739efc1da15521261da0092afa 
>   src/tests/containerizer/provisioner_docker_tests.cpp f81f0039dc12d09d85fda0be345d1509b4c6a664 
> 
> Diff: https://reviews.apache.org/r/42235/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 42235: Added protobuf for docker ImageReference and the parsing function.

Posted by Jie Yu <yu...@gmail.com>.

> On Jan. 18, 2016, 2:12 a.m., Guangya Liu wrote:
> > include/mesos/docker/spec.proto, line 33
> > <https://reviews.apache.org/r/42235/diff/2/?file=1199517#file1199517line33>
> >
> >     Can you please also add some comments here? The tag can be either "latest" or the image version.

Added.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42235/#review114929
-----------------------------------------------------------


On Jan. 18, 2016, 6:53 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42235/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2016, 6:53 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-4296
>     https://issues.apache.org/jira/browse/MESOS-4296
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The goal here is to replace Image::Name with ImageReference and the
> corresponding parsing method, which will be done in a subsequent patch.
> 
> 
> Diffs
> -----
> 
>   include/mesos/docker/spec.proto PRE-CREATION 
>   src/CMakeLists.txt 39a23df3227a4f524ea0d408dc894fa5bbab7d10 
>   src/Makefile.am d23e35001078a86775bd9b76baa207ecb9dab7e1 
>   src/docker/spec.hpp 822b2383c6d6bd691cb1fdbfcd699ae3ae3585bd 
>   src/docker/spec.cpp 0188078037b3528acefa42d39f05bd60789b19b2 
>   src/slave/containerizer/mesos/provisioner/docker/message.hpp 162e4c689bba832e523ff6b7d4e1e3c8e6713803 
>   src/slave/containerizer/mesos/provisioner/docker/message.proto 2b2ed056bd9acd341de0e5cbdb4eed711f3a0fe5 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp bd6dace826b3694748e4209dac5aa73256356f41 
>   src/tests/containerizer/docker_spec_tests.cpp aa4faf92e82acd739efc1da15521261da0092afa 
>   src/tests/containerizer/provisioner_docker_tests.cpp f81f0039dc12d09d85fda0be345d1509b4c6a664 
> 
> Diff: https://reviews.apache.org/r/42235/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 42235: Added protobuf for docker ImageReference and the parsing function.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42235/#review114929
-----------------------------------------------------------



include/mesos/docker/spec.proto (line 33)
<https://reviews.apache.org/r/42235/#comment175761>

    Can you please also add some comments here? The tag can be either "latest" or the image version.


- Guangya Liu


On 一月 17, 2016, 9:50 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42235/
> -----------------------------------------------------------
> 
> (Updated 一月 17, 2016, 9:50 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-4296
>     https://issues.apache.org/jira/browse/MESOS-4296
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The goal here is to replace Image::Name with ImageReference and the
> corresponding parsing method, which will be done in a subsequent patch.
> 
> 
> Diffs
> -----
> 
>   include/mesos/docker/spec.proto PRE-CREATION 
>   src/CMakeLists.txt 39a23df3227a4f524ea0d408dc894fa5bbab7d10 
>   src/Makefile.am d23e35001078a86775bd9b76baa207ecb9dab7e1 
>   src/docker/spec.hpp 822b2383c6d6bd691cb1fdbfcd699ae3ae3585bd 
>   src/docker/spec.cpp 0188078037b3528acefa42d39f05bd60789b19b2 
>   src/slave/containerizer/mesos/provisioner/docker/message.hpp 162e4c689bba832e523ff6b7d4e1e3c8e6713803 
>   src/slave/containerizer/mesos/provisioner/docker/message.proto 2b2ed056bd9acd341de0e5cbdb4eed711f3a0fe5 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp bd6dace826b3694748e4209dac5aa73256356f41 
>   src/tests/containerizer/docker_spec_tests.cpp aa4faf92e82acd739efc1da15521261da0092afa 
>   src/tests/containerizer/provisioner_docker_tests.cpp f81f0039dc12d09d85fda0be345d1509b4c6a664 
> 
> Diff: https://reviews.apache.org/r/42235/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 42235: Added protobuf for docker ImageReference and the parsing function.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42235/
-----------------------------------------------------------

(Updated Jan. 18, 2016, 8:13 a.m.)


Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.


Changes
-------

Fixed the dist make check issue.


Bugs: MESOS-4296
    https://issues.apache.org/jira/browse/MESOS-4296


Repository: mesos


Description
-------

The goal here is to replace Image::Name with ImageReference and the
corresponding parsing method, which will be done in a subsequent patch.


Diffs (updated)
-----

  include/mesos/docker/spec.proto PRE-CREATION 
  src/CMakeLists.txt 39a23df3227a4f524ea0d408dc894fa5bbab7d10 
  src/Makefile.am d23e35001078a86775bd9b76baa207ecb9dab7e1 
  src/docker/spec.hpp 822b2383c6d6bd691cb1fdbfcd699ae3ae3585bd 
  src/docker/spec.cpp 0188078037b3528acefa42d39f05bd60789b19b2 
  src/slave/containerizer/mesos/provisioner/docker/message.hpp 162e4c689bba832e523ff6b7d4e1e3c8e6713803 
  src/slave/containerizer/mesos/provisioner/docker/message.proto 2b2ed056bd9acd341de0e5cbdb4eed711f3a0fe5 
  src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp bd6dace826b3694748e4209dac5aa73256356f41 
  src/tests/containerizer/docker_spec_tests.cpp aa4faf92e82acd739efc1da15521261da0092afa 
  src/tests/containerizer/provisioner_docker_tests.cpp f81f0039dc12d09d85fda0be345d1509b4c6a664 

Diff: https://reviews.apache.org/r/42235/diff/


Testing
-------

make check


Thanks,

Jie Yu

Re: Review Request 42235: Added protobuf for docker ImageReference and the parsing function.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42235/#review114961
-----------------------------------------------------------

Ship it!


Ship It!

- Guangya Liu


On 一月 18, 2016, 6:57 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42235/
> -----------------------------------------------------------
> 
> (Updated 一月 18, 2016, 6:57 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-4296
>     https://issues.apache.org/jira/browse/MESOS-4296
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The goal here is to replace Image::Name with ImageReference and the
> corresponding parsing method, which will be done in a subsequent patch.
> 
> 
> Diffs
> -----
> 
>   include/mesos/docker/spec.proto PRE-CREATION 
>   src/CMakeLists.txt 39a23df3227a4f524ea0d408dc894fa5bbab7d10 
>   src/Makefile.am d23e35001078a86775bd9b76baa207ecb9dab7e1 
>   src/docker/spec.hpp 822b2383c6d6bd691cb1fdbfcd699ae3ae3585bd 
>   src/docker/spec.cpp 0188078037b3528acefa42d39f05bd60789b19b2 
>   src/slave/containerizer/mesos/provisioner/docker/message.hpp 162e4c689bba832e523ff6b7d4e1e3c8e6713803 
>   src/slave/containerizer/mesos/provisioner/docker/message.proto 2b2ed056bd9acd341de0e5cbdb4eed711f3a0fe5 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp bd6dace826b3694748e4209dac5aa73256356f41 
>   src/tests/containerizer/docker_spec_tests.cpp aa4faf92e82acd739efc1da15521261da0092afa 
>   src/tests/containerizer/provisioner_docker_tests.cpp f81f0039dc12d09d85fda0be345d1509b4c6a664 
> 
> Diff: https://reviews.apache.org/r/42235/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 42235: Added protobuf for docker ImageReference and the parsing function.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42235/
-----------------------------------------------------------

(Updated Jan. 18, 2016, 6:57 a.m.)


Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.


Changes
-------

Addressed comments.


Bugs: MESOS-4296
    https://issues.apache.org/jira/browse/MESOS-4296


Repository: mesos


Description
-------

The goal here is to replace Image::Name with ImageReference and the
corresponding parsing method, which will be done in a subsequent patch.


Diffs (updated)
-----

  include/mesos/docker/spec.proto PRE-CREATION 
  src/CMakeLists.txt 39a23df3227a4f524ea0d408dc894fa5bbab7d10 
  src/Makefile.am d23e35001078a86775bd9b76baa207ecb9dab7e1 
  src/docker/spec.hpp 822b2383c6d6bd691cb1fdbfcd699ae3ae3585bd 
  src/docker/spec.cpp 0188078037b3528acefa42d39f05bd60789b19b2 
  src/slave/containerizer/mesos/provisioner/docker/message.hpp 162e4c689bba832e523ff6b7d4e1e3c8e6713803 
  src/slave/containerizer/mesos/provisioner/docker/message.proto 2b2ed056bd9acd341de0e5cbdb4eed711f3a0fe5 
  src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp bd6dace826b3694748e4209dac5aa73256356f41 
  src/tests/containerizer/docker_spec_tests.cpp aa4faf92e82acd739efc1da15521261da0092afa 
  src/tests/containerizer/provisioner_docker_tests.cpp f81f0039dc12d09d85fda0be345d1509b4c6a664 

Diff: https://reviews.apache.org/r/42235/diff/


Testing
-------

make check


Thanks,

Jie Yu

Re: Review Request 42235: Added protobuf for docker ImageReference and the parsing function.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42235/
-----------------------------------------------------------

(Updated Jan. 18, 2016, 6:53 a.m.)


Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.


Changes
-------

Fixed the Makefile.


Bugs: MESOS-4296
    https://issues.apache.org/jira/browse/MESOS-4296


Repository: mesos


Description
-------

The goal here is to replace Image::Name with ImageReference and the
corresponding parsing method, which will be done in a subsequent patch.


Diffs (updated)
-----

  include/mesos/docker/spec.proto PRE-CREATION 
  src/CMakeLists.txt 39a23df3227a4f524ea0d408dc894fa5bbab7d10 
  src/Makefile.am d23e35001078a86775bd9b76baa207ecb9dab7e1 
  src/docker/spec.hpp 822b2383c6d6bd691cb1fdbfcd699ae3ae3585bd 
  src/docker/spec.cpp 0188078037b3528acefa42d39f05bd60789b19b2 
  src/slave/containerizer/mesos/provisioner/docker/message.hpp 162e4c689bba832e523ff6b7d4e1e3c8e6713803 
  src/slave/containerizer/mesos/provisioner/docker/message.proto 2b2ed056bd9acd341de0e5cbdb4eed711f3a0fe5 
  src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp bd6dace826b3694748e4209dac5aa73256356f41 
  src/tests/containerizer/docker_spec_tests.cpp aa4faf92e82acd739efc1da15521261da0092afa 
  src/tests/containerizer/provisioner_docker_tests.cpp f81f0039dc12d09d85fda0be345d1509b4c6a664 

Diff: https://reviews.apache.org/r/42235/diff/


Testing
-------

make check


Thanks,

Jie Yu

Re: Review Request 42235: Added protobuf for docker ImageReference and the parsing function.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42235/
-----------------------------------------------------------

(Updated Jan. 17, 2016, 9:50 p.m.)


Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.


Changes
-------

Rebased.


Bugs: MESOS-4296
    https://issues.apache.org/jira/browse/MESOS-4296


Repository: mesos


Description
-------

The goal here is to replace Image::Name with ImageReference and the
corresponding parsing method, which will be done in a subsequent patch.


Diffs (updated)
-----

  include/mesos/docker/spec.proto PRE-CREATION 
  src/CMakeLists.txt 39a23df3227a4f524ea0d408dc894fa5bbab7d10 
  src/Makefile.am d23e35001078a86775bd9b76baa207ecb9dab7e1 
  src/docker/spec.hpp 822b2383c6d6bd691cb1fdbfcd699ae3ae3585bd 
  src/docker/spec.cpp 0188078037b3528acefa42d39f05bd60789b19b2 
  src/slave/containerizer/mesos/provisioner/docker/message.hpp 162e4c689bba832e523ff6b7d4e1e3c8e6713803 
  src/slave/containerizer/mesos/provisioner/docker/message.proto 2b2ed056bd9acd341de0e5cbdb4eed711f3a0fe5 
  src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp bd6dace826b3694748e4209dac5aa73256356f41 
  src/tests/containerizer/docker_spec_tests.cpp aa4faf92e82acd739efc1da15521261da0092afa 
  src/tests/containerizer/provisioner_docker_tests.cpp f81f0039dc12d09d85fda0be345d1509b4c6a664 

Diff: https://reviews.apache.org/r/42235/diff/


Testing
-------

make check


Thanks,

Jie Yu