[jira] [Commented] (FLINK-5776) Improve XXMapRunner support create instance by carrying constructor parameters

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15889748#comment-15889748 ] 

ASF GitHub Bot commented on FLINK-5776:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3418#discussion_r103631417
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/FlatMapRunner.scala ---
    @@ -30,7 +30,9 @@ import org.slf4j.LoggerFactory
     class FlatMapRunner[IN, OUT](
         name: String,
         code: String,
    -    @transient returnType: TypeInformation[OUT])
    +    @transient returnType: TypeInformation[OUT],
    +    parameterValues: Array[_ <: Object] = null,
    --- End diff --
    
    Isn't Object too general? I think it needs to be `Serializable`.


> Improve XXMapRunner support create instance by carrying constructor parameters
> ------------------------------------------------------------------------------
>
>                 Key: FLINK-5776
>                 URL: https://issues.apache.org/jira/browse/FLINK-5776
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>
> At present, MapRunner FlatMapRunner only supports create non-parameter instance, but sometimes we need to carry constructor parameters to instantiate, so I would like to improve XXMapRunner support create instance by carrying constructor parameters.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)