[jira] [Commented] (KYLIN-4613) add buildCubeCLi as hadoop main class and jobRestClient

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KYLIN-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211545#comment-17211545 ] 

ASF GitHub Bot commented on KYLIN-4613:
---------------------------------------

hit-lacus commented on a change in pull request #1299:
URL: https://github.com/apache/kylin/pull/1299#discussion_r502742763



##########
File path: core-common/src/main/java/org/apache/kylin/common/KylinConfig.java
##########
@@ -134,7 +134,7 @@ private static void buildDefaultOrderedProperties() {
         }
     }
 
-    public static KylinConfig getInstanceFromEnv() {
+    public static KylinConfig getInstanceFromEnv(boolean allowConfigFileNoExist) {

Review comment:
       Why we need `allowConfigFileNoExist` ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> add buildCubeCLi as hadoop main class and  jobRestClient 
> ---------------------------------------------------------
>
>                 Key: KYLIN-4613
>                 URL: https://issues.apache.org/jira/browse/KYLIN-4613
>             Project: Kylin
>          Issue Type: Improvement
>          Components: Client - CLI
>            Reporter: chuxiao
>            Assignee: chuxiao
>            Priority: Minor
>
> support submit job and wait finish. retry 3 times when error。
> CubeBuildingCLIV2 不跟原来的兼容，是因为原来的依赖kylin部署环境，尤其是依赖kylin.properties，可以认为是给管理员用的。
> 而新的CubeBuildingCLIV2理念是给用户用的，参数完全在main方法里指定，不依赖kylin部署环境。所以无法合到一起。
> 至于 JobRestClient 不直接放到 RestClient里，是因为项目不同，放进去会有循环依赖。
> 后续一件事是把客户端单拎一个module，把包括建模在内的client都放进去，不依赖kylin其他非必要的module



--
This message was sent by Atlassian Jira
(v8.3.4#803005)