You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/07/18 05:13:17 UTC

[GitHub] [hbase] liuml07 commented on pull request #2044: HBASE-24709 Support MoveCostFunction use a lower multiplier in offpea…

liuml07 commented on pull request #2044:
URL: https://github.com/apache/hbase/pull/2044#issuecomment-660427619


   In my last comment,
   > That said, to remove this.conf = conf dependency, we can get two multipliers from config, and call setMultiplier() accordingly here in cost() by checking isOffPeakHour().
   
   I meant in constructor, we can get two multipliers from config and remove the `this.conf` field. In `cost()` we call `setMultiplier()`  and choose the right parameter by checking isOffPeakHour().


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org