You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by "e-strauss (via GitHub)" <gi...@apache.org> on 2025/04/15 12:58:32 UTC
[PR] [WIP] [SYSTEMDS-3842] Improve test coverage of API components: ScriptExecutorUtils, jmlc.Connection [systemds]
e-strauss opened a new pull request, #2253:
URL: https://github.com/apache/systemds/pull/2253
temporary code coverage report
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SYSTEMDS-3842] Improve test coverage of API components: ScriptExecutorUtils, jmlc.Connection [systemds]
Posted by "e-strauss (via GitHub)" <gi...@apache.org>.
e-strauss closed pull request #2253: [SYSTEMDS-3842] Improve test coverage of API components: ScriptExecutorUtils, jmlc.Connection
URL: https://github.com/apache/systemds/pull/2253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SYSTEMDS-3842] Improve test coverage of API components: ScriptExecutorUtils, jmlc.Connection [systemds]
Posted by "Baunsgaard (via GitHub)" <gi...@apache.org>.
Baunsgaard commented on PR #2253:
URL: https://github.com/apache/systemds/pull/2253#issuecomment-2876042313
LGTM, the failed tests are independent of the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] [SYSTEMDS-3842] Improve test coverage of API components: ScriptExecutorUtils, jmlc.Connection [systemds]
Posted by "fivemeyestoreserver (via GitHub)" <gi...@apache.org>.
fivemeyestoreserver commented on PR #2253:
URL: https://github.com/apache/systemds/pull/2253#issuecomment-2868840594
Excellent contribution to open source! The community will benefit greatly from this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] [SYSTEMDS-3842] Improve test coverage of API components: ScriptExecutorUtils, jmlc.Connection [systemds]
Posted by "Baunsgaard (via GitHub)" <gi...@apache.org>.
Baunsgaard commented on PR #2253:
URL: https://github.com/apache/systemds/pull/2253#issuecomment-2841278079
It looks like you have the same issue as Matthias on the main branch. We would have to look into this issue independently of the changes that you have made in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] [SYSTEMDS-3842] Improve test coverage of API components: ScriptExecutorUtils, jmlc.Connection [systemds]
Posted by "ayestoro (via GitHub)" <gi...@apache.org>.
ayestoro commented on PR #2253:
URL: https://github.com/apache/systemds/pull/2253#issuecomment-2868895307
The performance optimizations here are quite clever. Nice engineering work!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] [SYSTEMDS-3842] Improve test coverage of API components: ScriptExecutorUtils, jmlc.Connection [systemds]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2253:
URL: https://github.com/apache/systemds/pull/2253#issuecomment-2804987659
## [Codecov](https://app.codecov.io/gh/apache/systemds/pull/2253?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `0%` with `38 lines` in your changes missing coverage. Please review.
> Project coverage is 12.37%. Comparing base [(`cfbe190`)](https://app.codecov.io/gh/apache/systemds/commit/cfbe19062ab706c8acfc5bd688c04e20c3e9cbc5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`d61eba3`)](https://app.codecov.io/gh/apache/systemds/commit/d61eba35d22e7b090f03370fc0a4126b4a7ffaf2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 22 commits behind head on main.
| [Files with missing lines](https://app.codecov.io/gh/apache/systemds/pull/2253?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [src/main/java/org/apache/sysds/api/DMLOptions.java](https://app.codecov.io/gh/apache/systemds/pull/2253?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Fapi%2FDMLOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL2FwaS9ETUxPcHRpb25zLmphdmE=) | 0.00% | [38 Missing :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2253?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2253 +/- ##
=============================================
- Coverage 72.47% 12.37% -60.11%
+ Complexity 45466 7100 -38366
=============================================
Files 1469 1470 +1
Lines 170893 171213 +320
Branches 33325 33452 +127
=============================================
- Hits 123851 21182 -102669
- Misses 37632 145957 +108325
+ Partials 9410 4074 -5336
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/systemds/pull/2253?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org