You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/08/19 13:42:19 UTC

[GitHub] [hudi] codope opened a new pull request #3504: [MINOR] Use correct meta columns while preparing dataset for bulk insert

codope opened a new pull request #3504:
URL: https://github.com/apache/hudi/pull/3504


   ## What is the purpose of the pull request
   
   In absence of this fix, `_hoodie_is_deleted` will be considered as a meta field and placed at the beginning while reordering fields while preparing dataset for bulk insert.
   
   ## Brief change log
   
   *(for example:)*
     - *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] nsivabalan merged pull request #3504: [HUDI-2322] Use correct meta columns while preparing dataset for bulk insert

Posted by GitBox <gi...@apache.org>.
nsivabalan merged pull request #3504:
URL: https://github.com/apache/hudi/pull/3504


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3504: [MINOR] Use correct meta columns while preparing dataset for bulk insert

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3504:
URL: https://github.com/apache/hudi/pull/3504#issuecomment-901928777


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7def12b09ec4ef71c98355012ce54f1090678c1c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1813",
       "triggerID" : "7def12b09ec4ef71c98355012ce54f1090678c1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ea8d89a3c525af5a1b75dadd7b0aab93cbc6d34",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1815",
       "triggerID" : "5ea8d89a3c525af5a1b75dadd7b0aab93cbc6d34",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5ea8d89a3c525af5a1b75dadd7b0aab93cbc6d34 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1815) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3504: [MINOR] Use correct meta columns while preparing dataset for bulk insert

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3504:
URL: https://github.com/apache/hudi/pull/3504#issuecomment-901928777


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7def12b09ec4ef71c98355012ce54f1090678c1c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "7def12b09ec4ef71c98355012ce54f1090678c1c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7def12b09ec4ef71c98355012ce54f1090678c1c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3504: [MINOR] Use correct meta columns while preparing dataset for bulk insert

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3504:
URL: https://github.com/apache/hudi/pull/3504#issuecomment-901928777


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7def12b09ec4ef71c98355012ce54f1090678c1c",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1813",
       "triggerID" : "7def12b09ec4ef71c98355012ce54f1090678c1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ea8d89a3c525af5a1b75dadd7b0aab93cbc6d34",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1815",
       "triggerID" : "5ea8d89a3c525af5a1b75dadd7b0aab93cbc6d34",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7def12b09ec4ef71c98355012ce54f1090678c1c Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1813) 
   * 5ea8d89a3c525af5a1b75dadd7b0aab93cbc6d34 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1815) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3504: [MINOR] Use correct meta columns while preparing dataset for bulk insert

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3504:
URL: https://github.com/apache/hudi/pull/3504#issuecomment-901928777


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7def12b09ec4ef71c98355012ce54f1090678c1c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1813",
       "triggerID" : "7def12b09ec4ef71c98355012ce54f1090678c1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ea8d89a3c525af5a1b75dadd7b0aab93cbc6d34",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5ea8d89a3c525af5a1b75dadd7b0aab93cbc6d34",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7def12b09ec4ef71c98355012ce54f1090678c1c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1813) 
   * 5ea8d89a3c525af5a1b75dadd7b0aab93cbc6d34 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] vinothchandar commented on pull request #3504: [MINOR] Use correct meta columns while preparing dataset for bulk insert

Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #3504:
URL: https://github.com/apache/hudi/pull/3504#issuecomment-902003069


   @codope this does not seem like `MINOR`. can we file. JIRA for this fix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] nsivabalan commented on pull request #3504: [MINOR] Use correct meta columns while preparing dataset for bulk insert

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #3504:
URL: https://github.com/apache/hudi/pull/3504#issuecomment-901967776


   Will land once CI succeeds


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3504: [MINOR] Use correct meta columns while preparing dataset for bulk insert

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3504:
URL: https://github.com/apache/hudi/pull/3504#issuecomment-901928777


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7def12b09ec4ef71c98355012ce54f1090678c1c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1813",
       "triggerID" : "7def12b09ec4ef71c98355012ce54f1090678c1c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7def12b09ec4ef71c98355012ce54f1090678c1c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1813) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] codope commented on pull request #3504: [HUDI-2322] Use correct meta columns while preparing dataset for bulk insert

Posted by GitBox <gi...@apache.org>.
codope commented on pull request #3504:
URL: https://github.com/apache/hudi/pull/3504#issuecomment-902023373


   > @codope this does not seem like `MINOR`. can we file. JIRA for this fix
   
   Filed [JIRA](https://issues.apache.org/jira/browse/HUDI-2322) and updated PR title.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3504: [MINOR] Use correct meta columns while preparing dataset for bulk insert

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3504:
URL: https://github.com/apache/hudi/pull/3504#issuecomment-901928777


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7def12b09ec4ef71c98355012ce54f1090678c1c",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1813",
       "triggerID" : "7def12b09ec4ef71c98355012ce54f1090678c1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ea8d89a3c525af5a1b75dadd7b0aab93cbc6d34",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5ea8d89a3c525af5a1b75dadd7b0aab93cbc6d34",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7def12b09ec4ef71c98355012ce54f1090678c1c Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1813) 
   * 5ea8d89a3c525af5a1b75dadd7b0aab93cbc6d34 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org