You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2018/12/06 03:59:33 UTC

[kudu-CR] java: add log4j.properties file to kudu-test-utils module 

Hello Adar Dembo, Grant Henke,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/12040

to review the following change.


Change subject: java: add log4j.properties file to kudu-test-utils module
......................................................................

java: add log4j.properties file to kudu-test-utils module

This allows logging to function properly in this test

Change-Id: Ic57941d593c32d17c9619f51d18430a75e962635
---
A java/kudu-test-utils/src/test/resources/log4j.properties
1 file changed, 23 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/12040/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic57941d593c32d17c9619f51d18430a75e962635
Gerrit-Change-Number: 12040
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>

[kudu-CR] java: add log4j.properties file to kudu-test-utils module

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12040 )

Change subject: java: add log4j.properties file to kudu-test-utils module
......................................................................


Patch Set 3: Code-Review-1

I am inclined not to merge as-is, instead we should probably just add the one that is missing. What I see before this change is this:

mpercy@ve0518:~/src/kudu/java$ find . | grep xml | perl -pe 's/^..//; s{/.*}{};' | uniq
target
kudu_style.xml
kudu-test-utils
checkstyle_suppressions.xml
kudu-spark
kudu-hive
kudu-flume-sink
kudu-mapreduce
kudu-spark-tools
kudu-client
kudu-client-tools
kudu-backup

after this change I see this:

mpercy@ve0518:~/src/kudu/java$ find . | grep xml | perl -pe 's/^..//; s{/.*}{};' | uniq
target
kudu_style.xml
checkstyle_suppressions.xml
kudu-spark
kudu-client
kudu-backup

Obviously this change to the log4j.properties files is having unintended consequences. I am going to look into this a little more to try to understand what is going on.


-- 
To view, visit http://gerrit.cloudera.org:8080/12040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic57941d593c32d17c9619f51d18430a75e962635
Gerrit-Change-Number: 12040
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 12 Dec 2018 01:50:43 +0000
Gerrit-HasComments: No

[kudu-CR] java: add log4j.properties file to kudu-test-utils module

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12040 )

Change subject: java: add log4j.properties file to kudu-test-utils module
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/12040/2/java/kudu-spark-tools/src/test/resources/log4j.properties
File java/kudu-spark-tools/src/test/resources/log4j.properties:

http://gerrit.cloudera.org:8080/#/c/12040/2/java/kudu-spark-tools/src/test/resources/log4j.properties@23
PS2, Line 23: 
Here too?


http://gerrit.cloudera.org:8080/#/c/12040/2/java/kudu-spark/src/test/resources/log4j.properties
File java/kudu-spark/src/test/resources/log4j.properties:

http://gerrit.cloudera.org:8080/#/c/12040/2/java/kudu-spark/src/test/resources/log4j.properties@23
PS2, Line 23: 
Should we mark org.apache.spark as WARN?



-- 
To view, visit http://gerrit.cloudera.org:8080/12040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic57941d593c32d17c9619f51d18430a75e962635
Gerrit-Change-Number: 12040
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 11 Dec 2018 19:42:51 +0000
Gerrit-HasComments: Yes

[kudu-CR] java: add log4j.properties file to kudu-test-utils module

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12040 )

Change subject: java: add log4j.properties file to kudu-test-utils module
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12040/3/java/kudu-test-utils/src/test/resources/log4j.properties
File java/kudu-test-utils/src/test/resources/log4j.properties:

http://gerrit.cloudera.org:8080/#/c/12040/3/java/kudu-test-utils/src/test/resources/log4j.properties@21
PS3, Line 21: %F:%L
> Are you sure you want the logging file name and the line number of where th
That is an interesting observation and something we should look at for Spark integrations etc but this is for tests so I'm not worried about it in this context.



-- 
To view, visit http://gerrit.cloudera.org:8080/12040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic57941d593c32d17c9619f51d18430a75e962635
Gerrit-Change-Number: 12040
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 20 Dec 2018 05:48:05 +0000
Gerrit-HasComments: Yes

[kudu-CR] java: add log4j.properties file to kudu-test-utils module

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12040 )

Change subject: java: add log4j.properties file to kudu-test-utils module
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12040/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/12040/2//COMMIT_MSG@9
PS2, Line 9: This allows logging to function properly for tests in this module.
> What was the warning? You don't necessarily need to add it to the commit me
This is the warning:

log4j:WARN No appenders could be found for logger (org.apache.kudu.test.cluster.KuduBinaryLocator).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info.



-- 
To view, visit http://gerrit.cloudera.org:8080/12040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic57941d593c32d17c9619f51d18430a75e962635
Gerrit-Change-Number: 12040
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 20 Dec 2018 06:09:21 +0000
Gerrit-HasComments: Yes

[kudu-CR] java: add log4j.properties file to kudu-test-utils module

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12040 )

Change subject: java: add log4j.properties file to kudu-test-utils module
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic57941d593c32d17c9619f51d18430a75e962635
Gerrit-Change-Number: 12040
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 06 Dec 2018 15:08:29 +0000
Gerrit-HasComments: No

[kudu-CR] java: add log4j.properties file to kudu-test-utils module

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12040 )

Change subject: java: add log4j.properties file to kudu-test-utils module
......................................................................

java: add log4j.properties file to kudu-test-utils module

This allows logging to function properly for tests in this module.

It also squelches the following warning:

log4j:WARN No appenders could be found for logger (org.apache.kudu.test.cluster.KuduBinaryLocator).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info.

Change-Id: Ic57941d593c32d17c9619f51d18430a75e962635
Reviewed-on: http://gerrit.cloudera.org:8080/12040
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
A java/kudu-test-utils/src/test/resources/log4j.properties
1 file changed, 23 insertions(+), 0 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Grant Henke: Looks good to me, approved
  Adar Dembo: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/12040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic57941d593c32d17c9619f51d18430a75e962635
Gerrit-Change-Number: 12040
Gerrit-PatchSet: 5
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] java: add log4j.properties file to kudu-test-utils module

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12040 )

Change subject: java: add log4j.properties file to kudu-test-utils module
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/12040/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/12040/2//COMMIT_MSG@9
PS2, Line 9: This squelches a warning and allows logging to function for tests in
What was the warning? You don't necessarily need to add it to the commit message; just curious so we know to look out for it in the future.


http://gerrit.cloudera.org:8080/#/c/12040/2/java/kudu-test-utils/src/test/resources/log4j.properties
File java/kudu-test-utils/src/test/resources/log4j.properties:

http://gerrit.cloudera.org:8080/#/c/12040/2/java/kudu-test-utils/src/test/resources/log4j.properties@18
PS2, Line 18: log4j.rootLogger = WARN, out
I took a look at the other instances:

  java/kudu-backup/src/test/resources/log4j.properties:log4j.rootLogger = WARN, out
  java/kudu-client/src/test/resources/log4j.properties:log4j.rootLogger = DEBUG, out
  java/kudu-hive/src/test/resources/log4j.properties:log4j.rootLogger = DEBUG, out
  java/kudu-spark-tools/src/test/resources/log4j.properties:log4j.rootLogger = WARN, out
  java/kudu-spark/src/test/resources/log4j.properties:log4j.rootLogger = WARN, out

I imagine they should all be the same; which of WARN or DEBUG do you think is more appropriate?



-- 
To view, visit http://gerrit.cloudera.org:8080/12040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic57941d593c32d17c9619f51d18430a75e962635
Gerrit-Change-Number: 12040
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 06 Dec 2018 18:14:03 +0000
Gerrit-HasComments: Yes

[kudu-CR] java: add log4j.properties file to kudu-test-utils module

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12040

to look at the new patch set (#3).

Change subject: java: add log4j.properties file to kudu-test-utils module
......................................................................

java: add log4j.properties file to kudu-test-utils module

This allows logging to function properly for tests in this module.

Also normalize the logging level to INFO. Going forward, non-INFO
test logging levels should be added with a comment if needed.

Change-Id: Ic57941d593c32d17c9619f51d18430a75e962635
---
M java/kudu-backup/src/test/resources/log4j.properties
M java/kudu-client/src/test/resources/log4j.properties
M java/kudu-hive/src/test/resources/log4j.properties
M java/kudu-spark-tools/src/test/resources/log4j.properties
M java/kudu-spark/src/test/resources/log4j.properties
A java/kudu-test-utils/src/test/resources/log4j.properties
6 files changed, 26 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/12040/3
-- 
To view, visit http://gerrit.cloudera.org:8080/12040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic57941d593c32d17c9619f51d18430a75e962635
Gerrit-Change-Number: 12040
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] java: add log4j.properties file to kudu-test-utils module

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12040 )

Change subject: java: add log4j.properties file to kudu-test-utils module
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic57941d593c32d17c9619f51d18430a75e962635
Gerrit-Change-Number: 12040
Gerrit-PatchSet: 4
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 20 Dec 2018 16:10:31 +0000
Gerrit-HasComments: No

[kudu-CR] java: add log4j.properties file to kudu-test-utils module

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12040 )

Change subject: java: add log4j.properties file to kudu-test-utils module
......................................................................


Patch Set 4:

Rev 4 reverts back to adding the single missing file under kudu-test-utils/src/test


-- 
To view, visit http://gerrit.cloudera.org:8080/12040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic57941d593c32d17c9619f51d18430a75e962635
Gerrit-Change-Number: 12040
Gerrit-PatchSet: 4
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 20 Dec 2018 06:10:17 +0000
Gerrit-HasComments: No

[kudu-CR] java: add log4j.properties file to kudu-test-utils module

Posted by "Brian McDevitt (Code Review)" <ge...@cloudera.org>.
Brian McDevitt has posted comments on this change. ( http://gerrit.cloudera.org:8080/12040 )

Change subject: java: add log4j.properties file to kudu-test-utils module
......................................................................


Patch Set 3:

(1 comment)

One minor comment on the logging pattern.

http://gerrit.cloudera.org:8080/#/c/12040/3/java/kudu-test-utils/src/test/resources/log4j.properties
File java/kudu-test-utils/src/test/resources/log4j.properties:

http://gerrit.cloudera.org:8080/#/c/12040/3/java/kudu-test-utils/src/test/resources/log4j.properties@21
PS3, Line 21: %F:%L
Are you sure you want the logging file name and the line number of where the logging occurred?  It's not all that helpful and degrades performance.
From the docs: "WARNING Generating caller location information is extremely slow and should be avoided unless execution speed is not an issue."



-- 
To view, visit http://gerrit.cloudera.org:8080/12040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic57941d593c32d17c9619f51d18430a75e962635
Gerrit-Change-Number: 12040
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 20 Dec 2018 03:25:11 +0000
Gerrit-HasComments: Yes

[kudu-CR] java: add log4j.properties file to kudu-test-utils module

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12040 )

Change subject: java: add log4j.properties file to kudu-test-utils module
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic57941d593c32d17c9619f51d18430a75e962635
Gerrit-Change-Number: 12040
Gerrit-PatchSet: 4
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 20 Dec 2018 16:34:13 +0000
Gerrit-HasComments: No

[kudu-CR] java: add log4j.properties file to kudu-test-utils module

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12040

to look at the new patch set (#2).

Change subject: java: add log4j.properties file to kudu-test-utils module
......................................................................

java: add log4j.properties file to kudu-test-utils module

This squelches a warning and allows logging to function for tests in
this module.

Change-Id: Ic57941d593c32d17c9619f51d18430a75e962635
---
A java/kudu-test-utils/src/test/resources/log4j.properties
1 file changed, 23 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/12040/2
-- 
To view, visit http://gerrit.cloudera.org:8080/12040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic57941d593c32d17c9619f51d18430a75e962635
Gerrit-Change-Number: 12040
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] java: add log4j.properties file to kudu-test-utils module

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12040 )

Change subject: java: add log4j.properties file to kudu-test-utils module
......................................................................


Patch Set 3:

I am okay to have a single change adding the missing log4j.properties and optimizing/standardizing in a follow up.


-- 
To view, visit http://gerrit.cloudera.org:8080/12040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic57941d593c32d17c9619f51d18430a75e962635
Gerrit-Change-Number: 12040
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 12 Dec 2018 21:02:00 +0000
Gerrit-HasComments: No

[kudu-CR] java: add log4j.properties file to kudu-test-utils module

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Brian McDevitt, Kudu Jenkins, Adar Dembo, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12040

to look at the new patch set (#4).

Change subject: java: add log4j.properties file to kudu-test-utils module
......................................................................

java: add log4j.properties file to kudu-test-utils module

This allows logging to function properly for tests in this module.

It also squelches the following warning:

log4j:WARN No appenders could be found for logger (org.apache.kudu.test.cluster.KuduBinaryLocator).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info.

Change-Id: Ic57941d593c32d17c9619f51d18430a75e962635
---
A java/kudu-test-utils/src/test/resources/log4j.properties
1 file changed, 23 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/12040/4
-- 
To view, visit http://gerrit.cloudera.org:8080/12040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic57941d593c32d17c9619f51d18430a75e962635
Gerrit-Change-Number: 12040
Gerrit-PatchSet: 4
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>