[jira] [Commented] (HBASE-10048) Add hlog number metric in regionserver

["Himanshu Vashishtha (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13836076#comment-13836076 ] 

Himanshu Vashishtha commented on HBASE-10048:
---------------------------------------------

+1 to the idea of exposing log numbers, and thanks for the patch.
(I'd avoid doing the "numLogs +1" stuff, as it looks brittle). IMO, it is OKAY to show the rolled WALs and leave out the current one. And, name the metrics accordingly. What do you think [~lshmouse]?


[~zjushch]: Pardon for chiming in late; but couldn't just we make an intelligent "guess" about log size rather than creating a separate metrics for the same.
https://github.com/apache/hbase/blob/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java#L360

> Add hlog number metric in regionserver
> --------------------------------------
>
>                 Key: HBASE-10048
>                 URL: https://issues.apache.org/jira/browse/HBASE-10048
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Liu Shaohui
>            Assignee: Liu Shaohui
>            Priority: Minor
>         Attachments: HBASE-10048-0.94-v1.diff, HBASE-10048-0.94-v2.diff, HBASE-10048-trunk-v1.diff, HBASE-10048-trunk-v2.diff, HBASE-10048-trunk-v3.diff
>
>
> Add hlog number metric in regionserver. 
> We can use this metric to alert about memstore flush because of too many hlogs.



--
This message was sent by Atlassian JIRA
(v6.1#6144)