You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/11/26 02:44:34 UTC

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4851: Split BrokerReduceService code into ResultSetters

codecov-io edited a comment on issue #4851: Split BrokerReduceService code into ResultSetters
URL: https://github.com/apache/incubator-pinot/pull/4851#issuecomment-557738264
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4851?src=pr&el=h1) Report
   > Merging [#4851](https://codecov.io/gh/apache/incubator-pinot/pull/4851?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/e6e7bf92c947a91d5c1e45ba3fef2c35665df4e1?src=pr&el=desc) will **increase** coverage by `0.02%`.
   > The diff coverage is `50.28%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/4851/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/4851?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4851      +/-   ##
   ==========================================
   + Coverage   37.06%   37.08%   +0.02%     
   ==========================================
     Files        1197     1202       +5     
     Lines       64981    65036      +55     
     Branches     9457     9459       +2     
   ==========================================
   + Hits        24084    24119      +35     
   - Misses      38705    38750      +45     
   + Partials     2192     2167      -25
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4851?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...e/pinot/core/query/reduce/BrokerReduceService.java](https://codecov.io/gh/apache/incubator-pinot/pull/4851/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvQnJva2VyUmVkdWNlU2VydmljZS5qYXZh) | `91.2% <100%> (+35.7%)` | :arrow_up: |
   | [.../pinot/core/query/reduce/GroupByResultReducer.java](https://codecov.io/gh/apache/incubator-pinot/pull/4851/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvR3JvdXBCeVJlc3VsdFJlZHVjZXIuamF2YQ==) | `33.33% <33.33%> (ø)` | |
   | [...inot/core/query/reduce/SelectionResultReducer.java](https://codecov.io/gh/apache/incubator-pinot/pull/4851/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvU2VsZWN0aW9uUmVzdWx0UmVkdWNlci5qYXZh) | `69.56% <69.56%> (ø)` | |
   | [...pinot/core/query/reduce/DistinctResultReducer.java](https://codecov.io/gh/apache/incubator-pinot/pull/4851/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvRGlzdGluY3RSZXN1bHRSZWR1Y2VyLmphdmE=) | `72.09% <72.09%> (ø)` | |
   | [...ot/core/query/reduce/AggregationResultReducer.java](https://codecov.io/gh/apache/incubator-pinot/pull/4851/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvQWdncmVnYXRpb25SZXN1bHRSZWR1Y2VyLmphdmE=) | `86.11% <86.11%> (ø)` | |
   | [.../pinot/core/query/reduce/ResultReducerFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/4851/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvUmVzdWx0UmVkdWNlckZhY3RvcnkuamF2YQ==) | `90.9% <90.9%> (ø)` | |
   | [...ller/validation/OfflineSegmentIntervalChecker.java](https://codecov.io/gh/apache/incubator-pinot/pull/4851/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL09mZmxpbmVTZWdtZW50SW50ZXJ2YWxDaGVja2VyLmphdmE=) | `53.84% <0%> (-28.21%)` | :arrow_down: |
   | [...troller/helix/core/retention/RetentionManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4851/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JldGVudGlvbi9SZXRlbnRpb25NYW5hZ2VyLmphdmE=) | `11.11% <0%> (-19.45%)` | :arrow_down: |
   | [.../impl/dictionary/LongOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4851/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvTG9uZ09mZkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `48.38% <0%> (-13.98%)` | :arrow_down: |
   | [...r/validation/RealtimeSegmentValidationManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4851/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL1JlYWx0aW1lU2VnbWVudFZhbGlkYXRpb25NYW5hZ2VyLmphdmE=) | `68.33% <0%> (-11.67%)` | :arrow_down: |
   | ... and [54 more](https://codecov.io/gh/apache/incubator-pinot/pull/4851/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4851?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4851?src=pr&el=footer). Last update [e6e7bf9...db938f0](https://codecov.io/gh/apache/incubator-pinot/pull/4851?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org