You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "David Capwell (Jira)" <ji...@apache.org> on 2021/04/20 22:07:00 UTC

[jira] [Comment Edited] (CASSANDRA-16620) Improve failure message for rat plugin

    [ https://issues.apache.org/jira/browse/CASSANDRA-16620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326124#comment-17326124 ] 

David Capwell edited comment on CASSANDRA-16620 at 4/20/21, 10:06 PM:
----------------------------------------------------------------------

+1

tested trunk and saw the following

{code}
.build/build-rat.xml:65: Some files have missing or incorrect license information. Check RAT report in build/rat.txt for more details!
Unapproved licenses:

  src/java/org/apache/cassandra/utils/Mx4jTool.java

*******************************
{code}


The patch only takes the top 5 lines, which is 3 files at the most; but that should be a lot more helpful than 0 we do now.


was (Author: dcapwell):
tested trunk and saw the following

{code}
.build/build-rat.xml:65: Some files have missing or incorrect license information. Check RAT report in build/rat.txt for more details!
Unapproved licenses:

  src/java/org/apache/cassandra/utils/Mx4jTool.java

*******************************
{code}


The patch only takes the top 5 lines, which is 3 files at the most; but that should be a lot more helpful than 0 we do now.

> Improve failure message for rat plugin
> --------------------------------------
>
>                 Key: CASSANDRA-16620
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16620
>             Project: Cassandra
>          Issue Type: Task
>          Components: Build
>            Reporter: Michael Semb Wever
>            Assignee: Michael Semb Wever
>            Priority: Normal
>             Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0.x
>
>
> The RAT plugins failure message isn't informative, only referring to the file (build/rat.txt) where the offending files can be found.
> In CI systems, without access to that file, it is cumbersome to figure out what those offending files are.
> Add to the failure message a grep of the first few offending files.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org