You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "kevinjqliu (via GitHub)" <gi...@apache.org> on 2026/05/10 22:11:51 UTC

[PR] Remove stale `output/` directory and simplify `.htaccess` [datafusion-site]

kevinjqliu opened a new pull request, #180:
URL: https://github.com/apache/datafusion-site/pull/180

   
   ## What changes are included in this PR?
   
   **Note: This PR targets `asf-site` and should be merged after #179 (the `output: 'blog'` fix to `publish-site.yml`) has deployed.**
   
   1. Removes the `output/` directory — content is now built into `blog/` by the publish workflow.
   2. Strips `.htaccess` down to just the CSP directive, removing the rewrite rules that were a workaround for the `output/` → `blog/` mismatch.
   
   ### Verification before merging
   
   After the first PR deploys, verify that `blog/` and `output/` have identical content on `asf-site`:
   
   ```bash
   git fetch origin asf-site
   git worktree add /tmp/asf-site origin/asf-site
   diff -rq /tmp/asf-site/blog /tmp/asf-site/output
   git worktree remove /tmp/asf-site
   ```
   
   If `diff` reports no differences (or only expected ones like timestamps), it's safe to remove `output/`.
   
   ### Before
   ```
   asf-site/
   ├── .htaccess    (rewrite rules + CSP)
   └── output/      (build output, mapped to blog/ via rewrite)
   ```
   
   ### After
   ```
   asf-site/
   ├── .htaccess    (CSP only)
   └── blog/        (build output, served directly via .asf.yaml subdir)
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Remove stale `output/` directory and simplify `.htaccess` [datafusion-site]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #180:
URL: https://github.com/apache/datafusion-site/pull/180#issuecomment-4431331486

   Reverted in 
   - https://github.com/apache/datafusion-site/pull/182


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Remove stale `output/` directory and simplify `.htaccess` [datafusion-site]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #180:
URL: https://github.com/apache/datafusion-site/pull/180#issuecomment-4431508558

   > https://datafusion.apache.org/blog/ we're back!
   > 
   > now we just need to revert #179 so future deploys will land in the right folder
   
   Yes, can you please make a PR to do so (I can't approve my own PRs 😆  so if you make it I can approve and merge)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Remove stale `output/` directory and simplify `.htaccess` [datafusion-site]

Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #180:
URL: https://github.com/apache/datafusion-site/pull/180#issuecomment-4431310993

   revert #180 first then #179, that should do it
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Remove stale `output/` directory and simplify `.htaccess` [datafusion-site]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #180:
URL: https://github.com/apache/datafusion-site/pull/180#discussion_r3226104440


##########
.htaccess:
##########
@@ -1,31 +1,3 @@
-
-# redirect urls to the output directory

Review Comment:
   So nice!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Remove stale `output/` directory and simplify `.htaccess` [datafusion-site]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #180:
URL: https://github.com/apache/datafusion-site/pull/180#issuecomment-4420979761

   Thanks @kevinjqliu  -- this sounds good. I just merged https://github.com/apache/datafusion-site/pull/179
   
   Once taht gets in I'll re-review this one


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Remove stale `output/` directory and simplify `.htaccess` [datafusion-site]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #180:
URL: https://github.com/apache/datafusion-site/pull/180#issuecomment-4430553359

   If we don't figure this out shortly, I'll revert the changes so we can get the blog working correctly again


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Remove stale `output/` directory and simplify `.htaccess` [datafusion-site]

Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #180:
URL: https://github.com/apache/datafusion-site/pull/180#issuecomment-4431779032

   here it is: https://github.com/apache/datafusion-site/pull/184


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Remove stale `output/` directory and simplify `.htaccess` [datafusion-site]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #180:
URL: https://github.com/apache/datafusion-site/pull/180#issuecomment-4430214778

   🤔  the blog appears to be broken now:
   
   when I go to https://datafusion.apache.org/blog/
   
   I see:
   <img width="662" height="499" alt="Screenshot 2026-05-12 at 7 51 51 AM" src="https://github.com/user-attachments/assets/c06afea3-04b2-4554-82d7-1ef1a2786c27" />
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Remove stale `output/` directory and simplify `.htaccess` [datafusion-site]

Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #180:
URL: https://github.com/apache/datafusion-site/pull/180#issuecomment-4421686568

   #179 is merged, and i see that `blog/` now appears in the [`asf-site`](https://github.com/apache/datafusion-site/tree/asf-site) branch
   
   I verified that `blog/` and `output/` has the exact same content. 
   
   I think we can merge this one to see if it works @alamb 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Remove stale `output/` directory and simplify `.htaccess` [datafusion-site]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #180:
URL: https://github.com/apache/datafusion-site/pull/180


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Remove stale `output/` directory and simplify `.htaccess` [datafusion-site]

Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #180:
URL: https://github.com/apache/datafusion-site/pull/180#issuecomment-4431260344

   ok lets revert! sorry about that 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Remove stale `output/` directory and simplify `.htaccess` [datafusion-site]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #180:
URL: https://github.com/apache/datafusion-site/pull/180#issuecomment-4430195174

   > #179 is merged, and i see that `blog/` now appears in the [`asf-site`](https://github.com/apache/datafusion-site/tree/asf-site) branch I verified that `blog/` and `output/` has the exact same content.
   > 
   > I think we can merge this one to see if it works @alamb We **could** split this into 2 prs for safety (one to change `.htaccess`, another to remove `output/`)... but we can also just revert this pr if it doesnt work 😄
   
   Makes sense to me -- thank you again. 
   
   I didn't want to merge this. yesterday as I wanted to be around to make sure I could revert it if there was a problem


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Remove stale `output/` directory and simplify `.htaccess` [datafusion-site]

Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #180:
URL: https://github.com/apache/datafusion-site/pull/180#issuecomment-4431355946

   https://datafusion.apache.org/blog/ we're back! 
   
   now we just need to revert #179 so future deploys will land in the right folder 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Remove stale `output/` directory and simplify `.htaccess` [datafusion-site]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #180:
URL: https://github.com/apache/datafusion-site/pull/180#issuecomment-4431288477

   I will revert it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org