You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2018/03/28 10:44:39 UTC

[GitHub] janl commented on issue #1246: [DISCUSS] Remove duplicate authorisation check

janl commented on issue #1246: [DISCUSS] Remove duplicate authorisation check
URL: https://github.com/apache/couchdb/pull/1246#issuecomment-376842957
 
 
   @chewbranca good feedback, thanks.
   
   0. I agree that this should be reviewed VERY thoroughly, hence the controversially short PR, to solicit said review :)
   
   1. I care less about which duplicate we remove and more about making sure we only do it once. I chose to keep the one higher up the chain so we can avoid doing any more work as soon as we know we don’t have an auth match.
   
   2. I’d love to get cassim in. Did you have a chance to resolve the issues we found in the running up to 2.0?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services