[jira] [Commented] (CASSANDRA-3254) MessagingService sends blank bytes

["Jonathan Ellis (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113810#comment-13113810 ] 

Jonathan Ellis commented on CASSANDRA-3254:
-------------------------------------------

Do you see a performance difference in practice?

The problem is that this cuts down the extra bytes by adding copies to extra byte[], so I'm not sure it's a big win without avoiding the copies too a la CASSANDRA-1788.

> MessagingService sends blank bytes
> ----------------------------------
>
>                 Key: CASSANDRA-3254
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3254
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.8.6
>            Reporter: Greg Hinkle
>         Attachments: cassandra-0.8-3254.txt
>
>
> MessagingService is calling DataOutputBuffer.getData() instead of .asByteArray() in two places. This results in always sending the full buffer size of at least 128 bytes even if the message is smaller. For messages like gossip and single col mutations its around 40 to 80 bytes wasted per message.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira