You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/14 08:00:27 UTC

[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #782: drivers: wireless: Add support for UDP connect in gs2200m.c

masayuki2009 opened a new pull request #782: drivers: wireless: Add support for UDP connect in gs2200m.c
URL: https://github.com/apache/incubator-nuttx/pull/782
 
 
   ### Summary
   
   - Recently I noticed that DNS lookup fails on Spresense + GS2200M W-Fi module.
   - Finally I found that gs2200m driver did not consider connect() method for a UDP socket.
   - This PR creates a UDP client socket internally if connect() method is called for a UDP socket.
   
   ### Impact
   
   - This PR affects gs2200m driver and gs2200m_main.c (userland daemon)
   - I will send a separate PR to apps repository for it.
   
   ### Testing
   
   - Use spresense:wifi and connect to Wi-Fi access point
   - Then run 'renew eth0' to obtain IP address and run 'ntpcstart' to sync time to 'pool.ntp.org'
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #782: drivers: wireless: Add support for UDP connect in gs2200m.c

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on a change in pull request #782: drivers: wireless: Add support for UDP connect in gs2200m.c
URL: https://github.com/apache/incubator-nuttx/pull/782#discussion_r407989480
 
 

 ##########
 File path: drivers/wireless/gs2200m.c
 ##########
 @@ -1730,12 +1730,12 @@ enum pkt_type_e gs2200m_get_wstatus(FAR struct gs2200m_dev_s *dev)
 
 /****************************************************************************
  * Name: gs2200m_create_tcpc
- * NOTE: See 7.5.1.1 Create TCP Clients
+ * NOTE: See 7.5.1.1 Create TCP Clients and 7.5.2.2 Create UDP Client
 
 Review comment:
   > do you mean 7.5.1.2 ?
   
   You are right, I'll fix the comment later.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] jerpelea merged pull request #782: drivers: wireless: Add support for UDP connect in gs2200m.c

Posted by GitBox <gi...@apache.org>.
jerpelea merged pull request #782: drivers: wireless: Add support for UDP connect in gs2200m.c
URL: https://github.com/apache/incubator-nuttx/pull/782
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #782: drivers: wireless: Add support for UDP connect in gs2200m.c

Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #782: drivers: wireless: Add support for UDP connect in gs2200m.c
URL: https://github.com/apache/incubator-nuttx/pull/782#discussion_r407966081
 
 

 ##########
 File path: drivers/wireless/gs2200m.c
 ##########
 @@ -1730,12 +1730,12 @@ enum pkt_type_e gs2200m_get_wstatus(FAR struct gs2200m_dev_s *dev)
 
 /****************************************************************************
  * Name: gs2200m_create_tcpc
- * NOTE: See 7.5.1.1 Create TCP Clients
+ * NOTE: See 7.5.1.1 Create TCP Clients and 7.5.2.2 Create UDP Client
 
 Review comment:
   do you mean 7.5.1.2 ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] masayuki2009 commented on issue #782: drivers: wireless: Add support for UDP connect in gs2200m.c

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on issue #782: drivers: wireless: Add support for UDP connect in gs2200m.c
URL: https://github.com/apache/incubator-nuttx/pull/782#issuecomment-613771113
 
 
   This PR relates https://github.com/apache/incubator-nuttx/pull/664
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #782: drivers: wireless: Add support for UDP connect in gs2200m.c

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on a change in pull request #782: drivers: wireless: Add support for UDP connect in gs2200m.c
URL: https://github.com/apache/incubator-nuttx/pull/782#discussion_r408001970
 
 

 ##########
 File path: drivers/wireless/gs2200m.c
 ##########
 @@ -1730,12 +1730,12 @@ enum pkt_type_e gs2200m_get_wstatus(FAR struct gs2200m_dev_s *dev)
 
 /****************************************************************************
  * Name: gs2200m_create_tcpc
- * NOTE: See 7.5.1.1 Create TCP Clients
+ * NOTE: See 7.5.1.1 Create TCP Clients and 7.5.2.2 Create UDP Client
 
 Review comment:
   Just fixed and pushed -f.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services