You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beam.apache.org by Amit Sela <am...@gmail.com> on 2016/11/15 23:00:34 UTC
Jenkins skipping PreCommit for a PR caused build failures on master.
Jenkins had an outage which caused it to skip PreCommit execution for PR
#1332 <https://github.com/apache/incubator-beam/pull/1332>.
I reviewed this PR, and merged it.
I failed to notice that Jenkins skipped it, and so I merged it with a
missing license and checkstyle errors.
This spread-out across 3 PRs and a ticket now so I'll summarise here:
- Participating PRs: #1362
<https://github.com/apache/incubator-beam/pull/1362> #1364
<https://github.com/apache/incubator-beam/pull/1364> #1332
<https://github.com/apache/incubator-beam/pull/1332>
- Jenkins outage skipped (at least 1) PreCommit execution.
- A simple mvn install/verify won't execute checkstyle anymore, use:
"mvn -Prelease clean verify"
- Kenneth Knowles mentions we might have an issue with our configuration
as "mvn rat:check" fails on master (even after rollback)
Let's continue in this thread.
Thanks,
Amit
Re: Jenkins skipping PreCommit for a PR caused build failures on master.
Posted by Kenneth Knowles <kl...@google.com.INVALID>.
Thanks Dan!
`mvn apache-rat:check` appears to work on a clean master, but not my
checkout. I'll investigate where .gitignore and our configuration have
diverged. The report continues to include all excluded git blobs.
Can we disable the old plugin somehow?
On Tue, Nov 15, 2016 at 3:40 PM, Dan Halperin <dh...@google.com.invalid>
wrote:
> The command is apache-rat:check, not rat:check.
> http://creadur.apache.org/rat/apache-rat-plugin/
>
> rat:check is using the (very old) Maven2 plugin for RAT from the now
> defunct org.codehaus:
> https://mvnrepository.com/artifact/org.codehaus.mojo/
> rat-maven-plugin/1.0-alpha-3
>
> Dan
>
> On Wed, Nov 16, 2016 at 12:22 AM, Kenneth Knowles <kl...@google.com.invalid>
> wrote:
>
> > I honestly do not understand what is going on with our RAT set up. I'd
> also
> > love some docs on it.
> >
> > Jenkins fails on https://github.com/apache/incubator-beam/pull/1307
> saying
> > 1 file with unapproved license.
> > - There are no new files or changes to headers. So I assumed it was
> broken
> > on master and went to repro and got curious results.
> >
> > `mvn rat:check` on master after `git clean -d -f -x` fails with 6
> > unapproved licenses in the parent.
> > - But the report says there are 6 Apache Licensed files and 1640 unknown
> > licenses
> > - Internally consistent, the thing that occurs 6 times in the report is
> 6
> > AL files, such as .travis.yml and pom.xml, which are all good.
> > - The report lists excluded files as having unknown license or B for
> > binary, hence every .git thing, and the report is huge.
> >
> > `mvn rat:check -pl sdks/java/core` fails saying there are 662 unapproved
> > licenses.
> > - But, again, there are 662 good Apache License files and one unknown.
> > - And the unknown is user.avsc, which we explicitly exclude in our base
> > configuration.
> >
> > None of these results is correct. The latter two seem like the plugin
> > actually just has a bit flipped and also is not receiving our
> > configuration.
> >
> > On Tue, Nov 15, 2016 at 3:00 PM, Amit Sela <am...@gmail.com> wrote:
> >
> > > Jenkins had an outage which caused it to skip PreCommit execution for
> PR
> > > #1332 <https://github.com/apache/incubator-beam/pull/1332>.
> > >
> > > I reviewed this PR, and merged it.
> > > I failed to notice that Jenkins skipped it, and so I merged it with a
> > > missing license and checkstyle errors.
> > >
> > > This spread-out across 3 PRs and a ticket now so I'll summarise here:
> > >
> > > - Participating PRs: #1362
> > > <https://github.com/apache/incubator-beam/pull/1362> #1364
> > > <https://github.com/apache/incubator-beam/pull/1364> #1332
> > > <https://github.com/apache/incubator-beam/pull/1332>
> > > - Jenkins outage skipped (at least 1) PreCommit execution.
> > > - A simple mvn install/verify won't execute checkstyle anymore, use:
> > > "mvn -Prelease clean verify"
> > > - Kenneth Knowles mentions we might have an issue with our
> > configuration
> > > as "mvn rat:check" fails on master (even after rollback)
> > >
> > > Let's continue in this thread.
> > >
> > > Thanks,
> > > Amit
> > >
> >
>
Re: Jenkins skipping PreCommit for a PR caused build failures on master.
Posted by Dan Halperin <dh...@google.com.INVALID>.
The command is apache-rat:check, not rat:check.
http://creadur.apache.org/rat/apache-rat-plugin/
rat:check is using the (very old) Maven2 plugin for RAT from the now
defunct org.codehaus:
https://mvnrepository.com/artifact/org.codehaus.mojo/rat-maven-plugin/1.0-alpha-3
Dan
On Wed, Nov 16, 2016 at 12:22 AM, Kenneth Knowles <kl...@google.com.invalid>
wrote:
> I honestly do not understand what is going on with our RAT set up. I'd also
> love some docs on it.
>
> Jenkins fails on https://github.com/apache/incubator-beam/pull/1307 saying
> 1 file with unapproved license.
> - There are no new files or changes to headers. So I assumed it was broken
> on master and went to repro and got curious results.
>
> `mvn rat:check` on master after `git clean -d -f -x` fails with 6
> unapproved licenses in the parent.
> - But the report says there are 6 Apache Licensed files and 1640 unknown
> licenses
> - Internally consistent, the thing that occurs 6 times in the report is 6
> AL files, such as .travis.yml and pom.xml, which are all good.
> - The report lists excluded files as having unknown license or B for
> binary, hence every .git thing, and the report is huge.
>
> `mvn rat:check -pl sdks/java/core` fails saying there are 662 unapproved
> licenses.
> - But, again, there are 662 good Apache License files and one unknown.
> - And the unknown is user.avsc, which we explicitly exclude in our base
> configuration.
>
> None of these results is correct. The latter two seem like the plugin
> actually just has a bit flipped and also is not receiving our
> configuration.
>
> On Tue, Nov 15, 2016 at 3:00 PM, Amit Sela <am...@gmail.com> wrote:
>
> > Jenkins had an outage which caused it to skip PreCommit execution for PR
> > #1332 <https://github.com/apache/incubator-beam/pull/1332>.
> >
> > I reviewed this PR, and merged it.
> > I failed to notice that Jenkins skipped it, and so I merged it with a
> > missing license and checkstyle errors.
> >
> > This spread-out across 3 PRs and a ticket now so I'll summarise here:
> >
> > - Participating PRs: #1362
> > <https://github.com/apache/incubator-beam/pull/1362> #1364
> > <https://github.com/apache/incubator-beam/pull/1364> #1332
> > <https://github.com/apache/incubator-beam/pull/1332>
> > - Jenkins outage skipped (at least 1) PreCommit execution.
> > - A simple mvn install/verify won't execute checkstyle anymore, use:
> > "mvn -Prelease clean verify"
> > - Kenneth Knowles mentions we might have an issue with our
> configuration
> > as "mvn rat:check" fails on master (even after rollback)
> >
> > Let's continue in this thread.
> >
> > Thanks,
> > Amit
> >
>
Re: Jenkins skipping PreCommit for a PR caused build failures on master.
Posted by Kenneth Knowles <kl...@google.com.INVALID>.
I honestly do not understand what is going on with our RAT set up. I'd also
love some docs on it.
Jenkins fails on https://github.com/apache/incubator-beam/pull/1307 saying
1 file with unapproved license.
- There are no new files or changes to headers. So I assumed it was broken
on master and went to repro and got curious results.
`mvn rat:check` on master after `git clean -d -f -x` fails with 6
unapproved licenses in the parent.
- But the report says there are 6 Apache Licensed files and 1640 unknown
licenses
- Internally consistent, the thing that occurs 6 times in the report is 6
AL files, such as .travis.yml and pom.xml, which are all good.
- The report lists excluded files as having unknown license or B for
binary, hence every .git thing, and the report is huge.
`mvn rat:check -pl sdks/java/core` fails saying there are 662 unapproved
licenses.
- But, again, there are 662 good Apache License files and one unknown.
- And the unknown is user.avsc, which we explicitly exclude in our base
configuration.
None of these results is correct. The latter two seem like the plugin
actually just has a bit flipped and also is not receiving our configuration.
On Tue, Nov 15, 2016 at 3:00 PM, Amit Sela <am...@gmail.com> wrote:
> Jenkins had an outage which caused it to skip PreCommit execution for PR
> #1332 <https://github.com/apache/incubator-beam/pull/1332>.
>
> I reviewed this PR, and merged it.
> I failed to notice that Jenkins skipped it, and so I merged it with a
> missing license and checkstyle errors.
>
> This spread-out across 3 PRs and a ticket now so I'll summarise here:
>
> - Participating PRs: #1362
> <https://github.com/apache/incubator-beam/pull/1362> #1364
> <https://github.com/apache/incubator-beam/pull/1364> #1332
> <https://github.com/apache/incubator-beam/pull/1332>
> - Jenkins outage skipped (at least 1) PreCommit execution.
> - A simple mvn install/verify won't execute checkstyle anymore, use:
> "mvn -Prelease clean verify"
> - Kenneth Knowles mentions we might have an issue with our configuration
> as "mvn rat:check" fails on master (even after rollback)
>
> Let's continue in this thread.
>
> Thanks,
> Amit
>