You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joerg Schad <jo...@mesosphere.io> on 2015/11/17 18:19:21 UTC

Review Request 40392: Added force flag to override quota capacityHeuristic check.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40392/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov and Joris Van Remoortere.


Bugs: MESOS-3911
    https://issues.apache.org/jira/browse/MESOS-3911


Repository: mesos


Description
-------

Added force flag to override quota capacityHeuristic check.


Diffs
-----

  src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 
  src/tests/master_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/40392/diff/


Testing
-------

make check.


Thanks,

Joerg Schad

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

Posted by Joerg Schad <jo...@mesosphere.io>.

> On Nov. 18, 2015, 4:56 p.m., Alexander Rukletsov wrote:
> > src/master/quota_handler.cpp, line 224
> > <https://reviews.apache.org/r/40392/diff/2/?file=1128686#file1128686line224>
> >
> >     I'm a bit concerned whether it's a good solution to put this flag in the request body. I'd say better alternatives are:
> >     - A single JSON object per request (with the `force` flag inside);
> >     - `force` flag in the URL.
> >      
> >     What do you think?

see answer in my my review below.


- Joerg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40392/#review107041
-----------------------------------------------------------


On Nov. 17, 2015, 5:38 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40392/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2015, 5:38 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3911
>     https://issues.apache.org/jira/browse/MESOS-3911
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added force flag to override quota capacityHeuristic check.
> 
> 
> Diffs
> -----
> 
>   src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40392/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40392/#review107041
-----------------------------------------------------------



src/master/quota_handler.cpp (line 224)
<https://reviews.apache.org/r/40392/#comment165936>

    I'm a bit concerned whether it's a good solution to put this flag in the request body. I'd say better alternatives are:
    - A single JSON object per request (with the `force` flag inside);
    - `force` flag in the URL.
     
    What do you think?



src/tests/master_quota_tests.cpp (lines 129 - 134)
<https://reviews.apache.org/r/40392/#comment165935>

    I assume you introduce a separate function because you want to allow (and test) `force=false` as well, otherwise a single method suffices:
    ```
      string createRequestBody(const Resources& resources, bool force = false) const
      {
        string request = strings::format("resources=%s", JSON::protobuf(
            static_cast<const RepeatedPtrField<Resource>&>(resources))).get();
    
        if (force) {
          request + "&force=" + stringify<bool>(force);
        }
    
        return request;
      }
    ```
    
    However, we may still use a single method:
    ```
    string createRequestBody(const Resources& resources, Option<bool> force) const
    ```
    
    I think having a single method is cleaner and allow the reader to grasp all possibilities at once.



src/tests/master_quota_tests.cpp (line 456)
<https://reviews.apache.org/r/40392/#comment165937>

    This is not necessary any more.


- Alexander Rukletsov


On Nov. 17, 2015, 5:38 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40392/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2015, 5:38 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3911
>     https://issues.apache.org/jira/browse/MESOS-3911
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added force flag to override quota capacityHeuristic check.
> 
> 
> Diffs
> -----
> 
>   src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40392/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40392/#review106893
-----------------------------------------------------------


Bad patch!

Reviews applied: [39211, 39018, 39102, 36913, 38059, 39285, 38110, 40342, 40351]

Failed command: ./support/apply-review.sh -n -r 40351

Error:
 2015-11-17 17:49:58 URL:https://reviews.apache.org/r/40351/diff/raw/ [5865/5865] -> "40351.patch" [1]
error: patch failed: src/master/quota_handler.cpp:27
error: src/master/quota_handler.cpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Nov. 17, 2015, 5:38 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40392/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2015, 5:38 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3911
>     https://issues.apache.org/jira/browse/MESOS-3911
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added force flag to override quota capacityHeuristic check.
> 
> 
> Diffs
> -----
> 
>   src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40392/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

Posted by Joerg Schad <jo...@mesosphere.io>.

> On Nov. 18, 2015, 5:08 p.m., Joerg Schad wrote:
> > src/master/quota_handler.cpp, line 224
> > <https://reviews.apache.org/r/40392/diff/2/?file=1128686#file1128686line224>
> >
> >     As discussed offline I would prefere a single json object per request which is discussed by MESOS-3914. Until then I am ok with having the flag in the request body.

This is an answer to Alex question above.


- Joerg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40392/#review107047
-----------------------------------------------------------


On Nov. 17, 2015, 5:38 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40392/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2015, 5:38 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3911
>     https://issues.apache.org/jira/browse/MESOS-3911
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added force flag to override quota capacityHeuristic check.
> 
> 
> Diffs
> -----
> 
>   src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40392/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

Posted by Alexander Rukletsov <ru...@gmail.com>.

> On Nov. 18, 2015, 5:08 p.m., Joerg Schad wrote:
> > src/master/quota_handler.cpp, line 224
> > <https://reviews.apache.org/r/40392/diff/2/?file=1128686#file1128686line224>
> >
> >     As discussed offline I would prefere a single json object per request which is discussed by MESOS-3914. Until then I am ok with having the flag in the request body.
> 
> Joerg Schad wrote:
>     This is an answer to Alex question above.

I still think we should not ship the feature without cleaning this up. Filed: https://issues.apache.org/jira/browse/MESOS-3960


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40392/#review107047
-----------------------------------------------------------


On Nov. 19, 2015, 9:56 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40392/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 9:56 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3911
>     https://issues.apache.org/jira/browse/MESOS-3911
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added force flag to override quota capacityHeuristic check.
> 
> 
> Diffs
> -----
> 
>   src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40392/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40392/#review107047
-----------------------------------------------------------



src/master/quota_handler.cpp (line 224)
<https://reviews.apache.org/r/40392/#comment165945>

    As discussed offline I would prefere a single json object per request which is discussed by MESOS-3914. Until then I am ok with having the flag in the request body.



src/tests/master_quota_tests.cpp (lines 129 - 134)
<https://reviews.apache.org/r/40392/#comment165946>

    I will merge both functions.


- Joerg Schad


On Nov. 17, 2015, 5:38 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40392/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2015, 5:38 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3911
>     https://issues.apache.org/jira/browse/MESOS-3911
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added force flag to override quota capacityHeuristic check.
> 
> 
> Diffs
> -----
> 
>   src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40392/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40392/#review107375
-----------------------------------------------------------


Patch looks great!

Reviews applied: [39211, 39018, 39102, 36913, 38059, 39285, 38110, 40342, 40351, 38956, 40396, 39223, 40392]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 20, 2015, 9:39 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40392/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2015, 9:39 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3911
>     https://issues.apache.org/jira/browse/MESOS-3911
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added force flag to override quota capacityHeuristic check.
> 
> 
> Diffs
> -----
> 
>   src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40392/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40392/#review108059
-----------------------------------------------------------

Ship it!



src/master/quota_handler.cpp (line 302)
<https://reviews.apache.org/r/40392/#comment167432>

    s/overwrite/override/



src/master/quota_handler.cpp (line 303)
<https://reviews.apache.org/r/40392/#comment167433>

    should we lowercase the input value?



src/tests/master_quota_tests.cpp (lines 508 - 509)
<https://reviews.apache.org/r/40392/#comment167435>

    ```
    Checks that the force flag overrides the `capacityHeuristic` check.
    ```


- Joris Van Remoortere


On Nov. 20, 2015, 9:39 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40392/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2015, 9:39 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3911
>     https://issues.apache.org/jira/browse/MESOS-3911
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added force flag to override quota capacityHeuristic check.
> 
> 
> Diffs
> -----
> 
>   src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40392/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40392/
-----------------------------------------------------------

(Updated Nov. 20, 2015, 9:39 a.m.)


Review request for mesos, Alexander Rukletsov and Joris Van Remoortere.


Bugs: MESOS-3911
    https://issues.apache.org/jira/browse/MESOS-3911


Repository: mesos


Description
-------

Added force flag to override quota capacityHeuristic check.


Diffs (updated)
-----

  src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 
  src/tests/master_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/40392/diff/


Testing
-------

make check.


Thanks,

Joerg Schad

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40392/
-----------------------------------------------------------

(Updated Nov. 20, 2015, 5:44 a.m.)


Review request for mesos, Alexander Rukletsov and Joris Van Remoortere.


Changes
-------

Restored blank line.


Bugs: MESOS-3911
    https://issues.apache.org/jira/browse/MESOS-3911


Repository: mesos


Description
-------

Added force flag to override quota capacityHeuristic check.


Diffs (updated)
-----

  src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 
  src/tests/master_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/40392/diff/


Testing
-------

make check.


Thanks,

Joerg Schad

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

Posted by Alexander Rukletsov <ru...@gmail.com>.

> On Nov. 19, 2015, 11:10 p.m., Alexander Rukletsov wrote:
> > src/tests/master_quota_tests.cpp, line 460
> > <https://reviews.apache.org/r/40392/diff/4/?file=1132941#file1132941line460>
> >
> >     Could you please restore this blank line?
> 
> Joerg Schad wrote:
>     Sure, but FYI this style is consistent with the the rest of the file where we have one single line between TODO and first test (see line 155/156)

It makes sense to fix it where it was introduced to reduce noise. Agree?


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40392/#review107265
-----------------------------------------------------------


On Nov. 20, 2015, 5:44 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40392/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2015, 5:44 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3911
>     https://issues.apache.org/jira/browse/MESOS-3911
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added force flag to override quota capacityHeuristic check.
> 
> 
> Diffs
> -----
> 
>   src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40392/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

Posted by Joerg Schad <jo...@mesosphere.io>.

> On Nov. 19, 2015, 11:10 p.m., Alexander Rukletsov wrote:
> > src/tests/master_quota_tests.cpp, line 460
> > <https://reviews.apache.org/r/40392/diff/4/?file=1132941#file1132941line460>
> >
> >     Could you please restore this blank line?

Sure, but FYI this style is consistent with the the rest of the file where we have one single line between TODO and first test (see line 155/156)


- Joerg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40392/#review107265
-----------------------------------------------------------


On Nov. 19, 2015, 7:10 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40392/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 7:10 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3911
>     https://issues.apache.org/jira/browse/MESOS-3911
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added force flag to override quota capacityHeuristic check.
> 
> 
> Diffs
> -----
> 
>   src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40392/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40392/#review107265
-----------------------------------------------------------



src/tests/master_quota_tests.cpp 
<https://reviews.apache.org/r/40392/#comment166293>

    Could you please restore this blank line?


- Alexander Rukletsov


On Nov. 19, 2015, 7:10 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40392/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 7:10 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3911
>     https://issues.apache.org/jira/browse/MESOS-3911
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added force flag to override quota capacityHeuristic check.
> 
> 
> Diffs
> -----
> 
>   src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40392/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40392/
-----------------------------------------------------------

(Updated Nov. 19, 2015, 7:10 p.m.)


Review request for mesos, Alexander Rukletsov and Joris Van Remoortere.


Changes
-------

Removed rebase artifact.


Bugs: MESOS-3911
    https://issues.apache.org/jira/browse/MESOS-3911


Repository: mesos


Description
-------

Added force flag to override quota capacityHeuristic check.


Diffs (updated)
-----

  src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 
  src/tests/master_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/40392/diff/


Testing
-------

make check.


Thanks,

Joerg Schad

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40392/#review107166
-----------------------------------------------------------


Patch looks great!

Reviews applied: [39211, 39018, 39102, 36913, 38059, 39285, 38110, 40342, 40351, 38956, 40396, 39223, 40392]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 19, 2015, 9:56 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40392/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 9:56 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3911
>     https://issues.apache.org/jira/browse/MESOS-3911
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added force flag to override quota capacityHeuristic check.
> 
> 
> Diffs
> -----
> 
>   src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40392/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40392/#review107212
-----------------------------------------------------------

Ship it!



src/tests/master_quota_tests.cpp (lines 458 - 460)
<https://reviews.apache.org/r/40392/#comment166225>

    Looks like rebase artifact.


- Alexander Rukletsov


On Nov. 19, 2015, 9:56 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40392/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 9:56 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3911
>     https://issues.apache.org/jira/browse/MESOS-3911
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added force flag to override quota capacityHeuristic check.
> 
> 
> Diffs
> -----
> 
>   src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40392/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40392/
-----------------------------------------------------------

(Updated Nov. 19, 2015, 9:56 a.m.)


Review request for mesos, Alexander Rukletsov and Joris Van Remoortere.


Bugs: MESOS-3911
    https://issues.apache.org/jira/browse/MESOS-3911


Repository: mesos


Description
-------

Added force flag to override quota capacityHeuristic check.


Diffs (updated)
-----

  src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 
  src/tests/master_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/40392/diff/


Testing
-------

make check.


Thanks,

Joerg Schad

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40392/
-----------------------------------------------------------

(Updated Nov. 17, 2015, 5:38 p.m.)


Review request for mesos, Alexander Rukletsov and Joris Van Remoortere.


Bugs: MESOS-3911
    https://issues.apache.org/jira/browse/MESOS-3911


Repository: mesos


Description
-------

Added force flag to override quota capacityHeuristic check.


Diffs (updated)
-----

  src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 
  src/tests/master_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/40392/diff/


Testing
-------

make check.


Thanks,

Joerg Schad

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40392/#review106891
-----------------------------------------------------------


Bad patch!

Reviews applied: [39211, 39018, 39102, 36913, 38059, 39285, 38110, 40342, 40351]

Failed command: ./support/apply-review.sh -n -r 40351

Error:
 2015-11-17 17:19:57 URL:https://reviews.apache.org/r/40351/diff/raw/ [5865/5865] -> "40351.patch" [1]
error: patch failed: src/master/quota_handler.cpp:27
error: src/master/quota_handler.cpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Nov. 17, 2015, 5:19 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40392/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2015, 5:19 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3911
>     https://issues.apache.org/jira/browse/MESOS-3911
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added force flag to override quota capacityHeuristic check.
> 
> 
> Diffs
> -----
> 
>   src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40392/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>