You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/04/12 13:52:10 UTC
[GitHub] [mynewt-nimble] haukepetersen opened a new pull request #967: npl/riot: rework to use RIOTs ztimer
haukepetersen opened a new pull request #967:
URL: https://github.com/apache/mynewt-nimble/pull/967
ztimer is a new high-level timer API in RIOT that was introcuced a
while ago to be the successor of xtimer. This commit reworks the
RIOT NPL implementation to use ztimer instead of xtimer. This
simplifies the NPL implementation and it allows for significant
energy savings.
For the xtimer switch the implemenation further switches from
RIOTs `posix_semaphore` module to the slimmer `sema` module, as the
prior indirectly pulls in xtimer as dependency.
When running the `examples/nimble_gatt` application from RIOTs examples for the `nrf52dk` and compiling it without STDIO (so UART is not enabled), the average power consumption drops **from 430µA down to 72µA** while maintaining a BLE connection to a smartphone using the default connection interval :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] haukepetersen commented on pull request #967: npl/riot: rework to use RIOTs ztimer
Posted by GitBox <gi...@apache.org>.
haukepetersen commented on pull request #967:
URL: https://github.com/apache/mynewt-nimble/pull/967#issuecomment-820275191
Worked, Murdock is happy now :-)
All green -> go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] haukepetersen merged pull request #967: npl/riot: rework to use RIOTs ztimer
Posted by GitBox <gi...@apache.org>.
haukepetersen merged pull request #967:
URL: https://github.com/apache/mynewt-nimble/pull/967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #967: npl/riot: rework to use RIOTs ztimer
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on pull request #967:
URL: https://github.com/apache/mynewt-nimble/pull/967#issuecomment-817832209
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc commented on pull request #967: npl/riot: rework to use RIOTs ztimer
Posted by GitBox <gi...@apache.org>.
sjanc commented on pull request #967:
URL: https://github.com/apache/mynewt-nimble/pull/967#issuecomment-818614532
"make" -C /home/travis/gopath/src/github.com/apache/mynewt-nimble/RIOT/build/pkg/nimble/nimble/controller/src/ -f /home/travis/gopath/src/github.com/apache/mynewt-nimble/RIOT/Makefile.base MODULE=nimble_controller
3067In file included from /home/travis/gopath/src/github.com/apache/mynewt-nimble/RIOT/build/pkg/nimble/nimble/include/nimble/nimble_npl.h:53,
3068 from /home/travis/gopath/src/github.com/apache/mynewt-nimble/RIOT/build/pkg/nimble/porting/nimble/include/os/os.h:38,
3069 from /home/travis/gopath/src/github.com/apache/mynewt-nimble/RIOT/build/pkg/nimble/nimble/include/nimble/ble.h:26,
3070 from /home/travis/gopath/src/github.com/apache/mynewt-nimble/RIOT/build/pkg/nimble/nimble/controller/src/ble_ll_utils.c:22:
3071/home/travis/gopath/src/github.com/apache/mynewt-nimble/RIOT/build/pkg/nimble/porting/npl/riot/include/nimble/nimble_npl_os.h: In function 'ble_npl_eventq_get':
3072/home/travis/gopath/src/github.com/apache/mynewt-nimble/RIOT/build/pkg/nimble/porting/npl/riot/include/nimble/nimble_npl_os.h:103:40: error: implicit declaration of function 'event_wait_timeout_ztimer'; did you mean 'event_wait_timeout64'? [-Werror=implicit-function-declaration]
3073 return (struct ble_npl_event *)event_wait_timeout_ztimer(&evq->q,
3074 ^~~~~~~~~~~~~~~~~~~~~~~~~
3075 event_wait_timeout64
3076cc1: all warnings being treated as errors
include missing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #967: npl/riot: rework to use RIOTs ztimer
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #967:
URL: https://github.com/apache/mynewt-nimble/pull/967#issuecomment-817832209
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] haukepetersen commented on pull request #967: npl/riot: rework to use RIOTs ztimer
Posted by GitBox <gi...@apache.org>.
haukepetersen commented on pull request #967:
URL: https://github.com/apache/mynewt-nimble/pull/967#issuecomment-818623885
no, the problem is that the changes will only build correctly once also https://github.com/RIOT-OS/RIOT/pull/16317 is merged to RIOT, as in that PR some package dependencies used in the build are updated.
The specific error here is caused due to the fact, that the `event_wait_timeout_ztimer()` function is only included in the RIOT buil, if the `ztimer` module is pulled in. For the current package configuration that is not the case...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #967: npl/riot: rework to use RIOTs ztimer
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #967:
URL: https://github.com/apache/mynewt-nimble/pull/967#issuecomment-820249775
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] haukepetersen commented on pull request #967: npl/riot: rework to use RIOTs ztimer
Posted by GitBox <gi...@apache.org>.
haukepetersen commented on pull request #967:
URL: https://github.com/apache/mynewt-nimble/pull/967#issuecomment-819657196
I found a way to make Travis happy before I merge this: I will temporarily base the NimBLE package in RIOT on my feature branch and merge that PR into RIOT first. This way Travis should be able to built this PR and be happy, so we can merge it without bad feelings :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org