You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Guillaume Nodet (JIRA)" <ji...@apache.org> on 2013/05/17 10:05:16 UTC
[jira] [Commented] (SSHD-218) Can DefaultSshFuture.cancel() et.al.
can all be deleted?
[ https://issues.apache.org/jira/browse/SSHD-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13660459#comment-13660459 ]
Guillaume Nodet commented on SSHD-218:
--------------------------------------
The goal of the cancel() methods was to be called externally, mostly as a way to interrupt an ongoing connection attempt on the client side in that case.
So I don't really see any problem if it's not called internally, really, as it's not meant for that.
> Can DefaultSshFuture.cancel() et.al. can all be deleted?
> --------------------------------------------------------
>
> Key: SSHD-218
> URL: https://issues.apache.org/jira/browse/SSHD-218
> Project: MINA SSHD
> Issue Type: Bug
> Affects Versions: 0.8.0
> Reporter: Andrew C
>
> Stumbled across this.
> Turns out the only call to cancel(), for any *Future class, is in SshClient.connect(SocketAddress) with:
> if (future.isCanceled()) {
> connectFuture.cancel();
> which is pretty circular ...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira