You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by "daniellansun (via GitHub)" <gi...@apache.org> on 2024/01/20 16:25:37 UTC
[PR] GROOVY-11292: Class without sealed parent cannot be non-sealed [groovy]
daniellansun opened a new pull request, #2037:
URL: https://github.com/apache/groovy/pull/2037
https://issues.apache.org/jira/browse/GROOVY-11292
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GROOVY-11292: Class without sealed parent cannot be non-sealed [groovy]
Posted by "eric-milles (via GitHub)" <gi...@apache.org>.
eric-milles commented on PR #2037:
URL: https://github.com/apache/groovy/pull/2037#issuecomment-1902721131
Could you add the Java 19+ build stuff separately?
Is it possible to incorporate the non-sealed checking into `isSealed()` and then you would be checking `!isSealed()` instead of `isNonSealed()`? Otherwise if we need both `isSealed()` and `isNonSealed()` can they be stood up in `ClassNodeUtils` instead? These both came so quickly without much time to consider the impact to public API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GROOVY-11292: Class without sealed parent cannot be non-sealed [groovy]
Posted by "paulk-asert (via GitHub)" <gi...@apache.org>.
paulk-asert merged PR #2037:
URL: https://github.com/apache/groovy/pull/2037
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GROOVY-11292: Class without sealed parent cannot be non-sealed [groovy]
Posted by "daniellansun (via GitHub)" <gi...@apache.org>.
daniellansun commented on PR #2037:
URL: https://github.com/apache/groovy/pull/2037#issuecomment-1902735259
> Could you add the Java 19+ build stuff separately?
Sure. I just want to see if the fix works for Java 19+.
> Is it possible to incorporate the non-sealed checking into isSealed() and then you would be checking !isSealed() instead of isNonSealed()?
`isNonSealed()` means the type is declared `non-sealed`, it is not `sealed` and its parent must be `sealed`, so `isNonSealed()` can not just be expressed by `!isSealed()`. So I would like to accept your suggestion putting `isNonSealed()` into `ClassNodeUtils`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GROOVY-11292: Class without sealed parent cannot be non-sealed [groovy]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2037:
URL: https://github.com/apache/groovy/pull/2037#issuecomment-1902171856
## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2037?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `2 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`ed9204d`)](https://app.codecov.io/gh/apache/groovy/commit/ed9204dc37cce76f6d099e59608a5e9aa0ac5e33?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 68.5466% compared to head [(`a6adcfc`)](https://app.codecov.io/gh/apache/groovy/pull/2037?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 68.5522%.
> :exclamation: Current head a6adcfc differs from pull request most recent head cd4c71f. Consider uploading reports for the commit cd4c71f to get more accurate results
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/2037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #2037 +/- ##
==================================================
+ Coverage 68.5466% 68.5522% +0.0057%
- Complexity 29118 29131 +13
==================================================
Files 1422 1422
Lines 113482 113493 +11
Branches 19521 19526 +5
==================================================
+ Hits 77788 77802 +14
+ Misses 29157 29155 -2
+ Partials 6537 6536 -1
```
| [Files](https://app.codecov.io/gh/apache/groovy/pull/2037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ehaus/groovy/classgen/ClassCompletionVerifier.java](https://app.codecov.io/gh/apache/groovy/pull/2037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL0NsYXNzQ29tcGxldGlvblZlcmlmaWVyLmphdmE=) | `85.3448% <100.0000%> (ø)` | |
| [...c/main/java/org/codehaus/groovy/ast/ClassNode.java](https://app.codecov.io/gh/apache/groovy/pull/2037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2FzdC9DbGFzc05vZGUuamF2YQ==) | `87.5969% <80.0000%> (-0.0593%)` | :arrow_down: |
| [...aus/groovy/ast/decompiled/DecompiledClassNode.java](https://app.codecov.io/gh/apache/groovy/pull/2037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2FzdC9kZWNvbXBpbGVkL0RlY29tcGlsZWRDbGFzc05vZGUuamF2YQ==) | `88.7755% <83.3333%> (-0.3549%)` | :arrow_down: |
... and [6 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2037/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org