[GitHub] [skywalking] viswaramamoorthy commented on a change in pull request #3761: Rabbitmq instrument consumer class correctly to get duration reported…

[GitBox <gi...@apache.org>]

viswaramamoorthy commented on a change in pull request #3761: Rabbitmq instrument consumer class correctly to get duration reported…
URL: https://github.com/apache/skywalking/pull/3761#discussion_r341809609
 
 

 ##########
 File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/match/HierarchyMatch.java
 ##########
 @@ -46,6 +47,11 @@ private HierarchyMatch(String[] parentTypes) {
         this.parentTypes = parentTypes;
     }
 
+    private HierarchyMatch(String[] parentTypes, boolean interfaceOnlyMatch) {
+        this(parentTypes);
+        this.interfaceOnlyMatch = interfaceOnlyMatch;
+    }
+
 
 Review comment:
   RabbitMQ client pretty much leaves the message handling implementation to a custom class or a framework like Camel's RabbitMQ module or a Spring. We need to discover and instrument implementation classes of com.rabbitmq.client.Consumer
   
   We cannot use HierarchyMtach as is. if we did, in this case, it might discover an interface that extends from com.rabbitmq.client.Consumer which will result in undesired behavior
   
   So, HierarchyMtach is lacking and ideally should have a feature to just match interfaces only. 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services