You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "cyd257666 (via GitHub)" <gi...@apache.org> on 2024/01/09 15:47:40 UTC
[PR] [Feature][doc] Add V2 connector jdbc document parameter can speed up … [seatunnel]
cyd257666 opened a new pull request, #6168:
URL: https://github.com/apache/seatunnel/pull/6168
…data import
https://github.com/apache/seatunnel/issues/6167
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
### Purpose of this pull request
Add a parameter was found in the JdbcOptions interface of the source code, but it is not included in the official documentation 2.3.3,I tested that connecting to MySQL or Greenplum using jdbc and changing the default value of this parameter from true to false can accelerate the data import speed during the snapshot phase. If there is a chance to merge, I am willing to update other versions of the Markdown document as well
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released SeaTunnel versions or within the unreleased branches such as dev.
If no, write 'No'.
If you are adding/modifying connector documents, please follow our new specifications: https://github.com/apache/seatunnel/issues/4544.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If you are adding E2E test cases, maybe refer to https://github.com/apache/seatunnel/blob/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-mysql-e2e/src/test/resources/mysqlcdc_to_mysql.conf, here is a good example.
-->
### Check list
* [x] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
* [x] If you are contributing the connector code, please check that the following files are updated:
1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/seatunnel/tree/dev/docs/en/connector-v2)
2. Update [plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
3. Update the pom file of [seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
* [x] Update the [`release-note`](https://github.com/apache/seatunnel/blob/dev/release-note.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature][doc] Add V2 connector jdbc document parameter can speed up … [seatunnel]
Posted by "EricJoy2048 (via GitHub)" <gi...@apache.org>.
EricJoy2048 commented on PR #6168:
URL: https://github.com/apache/seatunnel/pull/6168#issuecomment-1884066682
There's a problem.
If you want to modify a document that has already been published, you need to directly modify it in the seatunnel website repository and merge it to the main branch.
If you want to make changes when the next version is released, you can do so in the seatunel repository and merge to the dev branch.
If you want to make changes to both the previous version of the document and the next version, then both repositories should provide separate PRs.
In addition, this parameter is not only added to the jdbc sink document, but also to the database documents, such as sink/mysql.md, sink/oracle.md, and so on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature][doc] Add V2 connector jdbc document parameter can speed up … [seatunnel]
Posted by "cyd257666 (via GitHub)" <gi...@apache.org>.
cyd257666 closed pull request #6168: [Feature][doc] Add V2 connector jdbc document parameter can speed up …
URL: https://github.com/apache/seatunnel/pull/6168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature][doc] Add V2 connector jdbc document parameter can speed up … [seatunnel]
Posted by "cyd257666 (via GitHub)" <gi...@apache.org>.
cyd257666 commented on PR #6168:
URL: https://github.com/apache/seatunnel/pull/6168#issuecomment-1884100409
copy that,i will summit resubmit to `main` branch and `dev` branch today
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org