You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "aimtsou (via GitHub)" <gi...@apache.org> on 2023/04/17 07:31:35 UTC
[GitHub] [spark] aimtsou opened a new pull request, #40819: [SPARK-43160][PYTHON]: Removed typing.io deprecated namespace
aimtsou opened a new pull request, #40819:
URL: https://github.com/apache/spark/pull/40819
### Problem Description
From python 3.12 and onward or 3.13 according to the references [1](https://bugs.python.org/issue35089), [2](https://docs.python.org/3/library/typing.html#typing.IO) the typing.io namespace will be removed.
```
/python/3.11.1/lib/python3.11/site-packages/pyspark/broadcast.py:38: DeprecationWarning: typing.io is deprecated, import directly from typing instead. typing.io will be removed in Python 3.12.
from typing.io import BinaryIO # type: ignore[import]
```
### What changes were proposed in this pull request?
I am fixing the issue with the usage of typing.io
### Why are the changes needed?
Because typing.io namespace will be removed [1](https://bugs.python.org/issue35089), [2](https://docs.python.org/3/library/typing.html#typing.IO)
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
By running the tests: https://github.com/aimtsou/spark/actions/runs/4718557460
### Jira ticket
https://issues.apache.org/jira/browse/SPARK-43160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #40819: [WIP][SPARK-43160][PYTHON]: Removed typing.io deprecated namespace
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #40819: [WIP][SPARK-43160][PYTHON]: Removed typing.io deprecated namespace
URL: https://github.com/apache/spark/pull/40819
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] aimtsou commented on pull request #40819: [WIP][SPARK-43160][PYTHON]: Removed typing.io deprecated namespace
Posted by "aimtsou (via GitHub)" <gi...@apache.org>.
aimtsou commented on PR #40819:
URL: https://github.com/apache/spark/pull/40819#issuecomment-1510871407
One of the tests fail but I wonder why this should not be due to import:
`starting mypy annotations test...
annotations failed mypy checks:
python/pyspark/broadcast.py:100: error: Overloaded function implementation does not accept all possible arguments of signature 3 [misc]
Found 1 error in 1 file (checked 505 source files)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #40819: [WIP][SPARK-43160][PYTHON]: Removed typing.io deprecated namespace
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40819:
URL: https://github.com/apache/spark/pull/40819#issuecomment-1654790765
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org