You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by gr...@apache.org on 2017/11/15 19:41:10 UTC

[1/2] mesos git commit: Added quick start instructions for CMake.

Repository: mesos
Updated Branches:
  refs/heads/master f1c861de6 -> e3e641328


Added quick start instructions for CMake.

Review: https://reviews.apache.org/r/63818/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/f67b63db
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/f67b63db
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/f67b63db

Branch: refs/heads/master
Commit: f67b63dbd68bb875bb25011014774264b7f0db3e
Parents: f1c861d
Author: Andrew Schwartzmeyer <an...@schwartzmeyer.com>
Authored: Wed Nov 15 11:35:36 2017 -0800
Committer: Greg Mann <gr...@gmail.com>
Committed: Wed Nov 15 11:36:10 2017 -0800

----------------------------------------------------------------------
 docs/cmake.md | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/f67b63db/docs/cmake.md
----------------------------------------------------------------------
diff --git a/docs/cmake.md b/docs/cmake.md
index b8f9e7c..507c689 100644
--- a/docs/cmake.md
+++ b/docs/cmake.md
@@ -31,6 +31,31 @@ Download and install the MSI from [CMake.org][cmake-download].
 
 **NOTE:** Windows needs CMake 3.8+, rather than 3.7+.
 
+# Quick Start
+
+The most basic way to build with CMake, with no configuration, is fairly
+straightforward:
+
+```
+mkdir build
+cd build
+cmake ..
+cmake --build .
+```
+
+The last step, `cmake --build .` can also take a `--target` command to build any
+particular target (e.g. `mesos-tests`, or `tests` to build `mesos-tests`,
+`libprocess-tests`, and `stout-tests`): `cmake --build . --target tests`. To
+send arbitrary flags to the native build system underneath (e.g. `make`), append
+the command with `-- <flags to be passed>`: `cmake --build . -- -j4`.
+
+Also, `cmake --build` can be substituted by your build system of choice. For
+instance, the default CMake generator on Linux produces GNU Makefiles, so after
+configuring with `cmake ..`, you can just run `make tests` in the `build` folder
+like usual. Similarly, if you configure with `-G Ninja` to use the Ninja
+generator, you can then run `ninja tests` to build the `tests` target with
+Ninja.
+
 # Supported options
 
 See [configuration options](configuration/cmake.md).


[2/2] mesos git commit: Removed an unused variable in a default executor test.

Posted by gr...@apache.org.
Removed an unused variable in a default executor test.

This patch removes an unused variable from
`DefaultExecutorTest.CommitSuicideOnKillTask`.

Review: https://reviews.apache.org/r/63522/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/e3e64132
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/e3e64132
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/e3e64132

Branch: refs/heads/master
Commit: e3e6413281f81e53c845a5c6e2cc57c1e6ece110
Parents: f67b63d
Author: Gaston Kleiman <ga...@mesosphere.io>
Authored: Wed Nov 15 11:35:56 2017 -0800
Committer: Greg Mann <gr...@gmail.com>
Committed: Wed Nov 15 11:39:29 2017 -0800

----------------------------------------------------------------------
 src/tests/default_executor_tests.cpp | 2 --
 1 file changed, 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/e3e64132/src/tests/default_executor_tests.cpp
----------------------------------------------------------------------
diff --git a/src/tests/default_executor_tests.cpp b/src/tests/default_executor_tests.cpp
index 6511398..6515021 100644
--- a/src/tests/default_executor_tests.cpp
+++ b/src/tests/default_executor_tests.cpp
@@ -1090,8 +1090,6 @@ TEST_P(DefaultExecutorTest, CommitSuicideOnKillTask)
 
   v1::TaskInfo task2 = v1::createTask(agentId, resources, SLEEP_COMMAND(1000));
 
-  const hashset<v1::TaskID> taskIds{task1.task_id(), task2.task_id()};
-
   // We expect two TASK_STARTING, two TASK_RUNNING, and one TASK_FINISHED
   // updates.
   vector<Future<v1::scheduler::Event::Update>> updates(5);