You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "CAICAIIs (via GitHub)" <gi...@apache.org> on 2025/07/29 17:28:25 UTC
[PR] fix: add missing dubbo.application.name for docker sample [dubbo-samples]
CAICAIIs opened a new pull request, #1241:
URL: https://github.com/apache/dubbo-samples/pull/1241
## Problem Description
Fix the issue where application name logs were not being printed normally in Dubbo samples due to missing `dubbo.application.name` configuration. Previously, samples would output `Dubbo Application[1.0](unknown) is created` instead of showing the proper application name.
## Changes Made
- Add missing `dubbo.application.name` configuration in docker sample
- Only modify samples that previously output the application name as 'unknown'
## Files Modified
- `2-advanced/dubbo-samples-docker/src/main/resources/application.properties`
## Technical Details
- Added `dubbo.application.name=dubbo-samples-docker-provider` to application.properties
## Related Issue
Related to apache/dubbo#15473
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix: add missing dubbo.application.name for docker sample [dubbo-samples]
Posted by "CAICAIIs (via GitHub)" <gi...@apache.org>.
CAICAIIs commented on PR #1241:
URL: https://github.com/apache/dubbo-samples/pull/1241#issuecomment-3135783766
> ```
> @ImportResource("classpath:dubbo-docker-provider.xml")
> public class DubboApplication {
> ```
>
> it was defined at dubbo-docker-provider.xml, ` <dubbo:application name="dubbo-docker-provider"/>`
>
> by the way, `dubbo-samples-docker` has not been tested by now because it requires springboot 1.x which is outdated.
Thank you for the code review. I’ll be more careful next time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix: add missing dubbo.application.name for docker sample [dubbo-samples]
Posted by "zrlw (via GitHub)" <gi...@apache.org>.
zrlw commented on PR #1241:
URL: https://github.com/apache/dubbo-samples/pull/1241#issuecomment-3135761467
```
@ImportResource("classpath:dubbo-docker-provider.xml")
public class DubboApplication {
```
it was defined at dubbo-docker-provider.xml,
``` <dubbo:application name="dubbo-docker-provider"/>```
by the way, ```dubbo-samples-docker``` has not been tested by now because it require springboot 1.x which is outdated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix: add missing dubbo.application.name for docker sample [dubbo-samples]
Posted by "zrlw (via GitHub)" <gi...@apache.org>.
zrlw closed pull request #1241: fix: add missing dubbo.application.name for docker sample
URL: https://github.com/apache/dubbo-samples/pull/1241
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org